Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat sorting #779

Open
3 tasks
Tracked by #14513 ...
saeedashrraf opened this issue Apr 2, 2022 · 7 comments
Open
3 tasks
Tracked by #14513 ...

Reformat sorting #779

saeedashrraf opened this issue Apr 2, 2022 · 7 comments
Labels
Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide hacktoberfest hacktoberfest ToDo A ToDo list of tasks

Comments

@saeedashrraf
Copy link
Contributor

saeedashrraf commented Apr 2, 2022

As explained in the function reformatting open task, each function in the sorting submodule should be updated to follow the implementation instructions given in the Deep Dive section of the docs. The updates should be applied for both the Ivy API and Backend API. The Deep Dive is the best general resource for learning in detail how functions should be implemented. Many of the functions are not implemented as they should be. You will need to make changes to the current implementations, but you do not need to go through all section of the Deep Dive. Specifically, you should make the following changes, where appropriate:

  1. remove all lambda and direct bindings for backend functions, with each function instead defined using def.
  2. update the function arguments and type hints.
  3. add the correct docstrings
  4. add thorough docstring examples

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.

_

@saeedashrraf saeedashrraf added ToDo A ToDo list of tasks Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide labels Apr 2, 2022
@bideeen bideeen mentioned this issue Apr 2, 2022
@github-actions github-actions bot deleted a comment from bideeen Apr 3, 2022
@github-actions github-actions bot deleted a comment from bethelhall Apr 3, 2022
@ivy-llc ivy-llc deleted a comment from Daniel4078 May 14, 2022
@ivy-llc ivy-llc deleted a comment from VidyashreeEshwarappa Jun 27, 2022
@ivy-llc ivy-llc deleted a comment from ukj02 Jul 27, 2022
@ivy-llc ivy-llc deleted a comment from VidyashreeEshwarappa Jul 27, 2022
@ivy-llc ivy-llc deleted a comment from drhuazhao Aug 30, 2022
@ivy-llc ivy-llc deleted a comment from Adlai-1 Sep 19, 2022
@trihernandez
Copy link
Contributor

trihernandez commented Sep 30, 2022

@vishwasjoshi2019
Copy link

Hi @trihernandez @saeedashrraf @sreegandh804 @Aarsh2001 @thecoder12 , I want to work on this issue, can you please assign this to me.

@Abhinav-CHD
Copy link
Contributor

Hey is anyone working on this issue? If not, then I would like to work on it.

@vishwasjoshi2019
Copy link

hey @Abhinav-CHD I'm working on it

@Abhinav-CHD
Copy link
Contributor

hey @Abhinav-CHD I'm working on it

Okay

@anudeeps0306
Copy link
Contributor

@Abhinav-CHD can you check my pr request #23593

@a0m0rajab a0m0rajab added the hacktoberfest hacktoberfest label Sep 25, 2023
@ivy-llc ivy-llc deleted a comment from 2202-Aryan Oct 4, 2023
@SilverSnake0
Copy link

#25680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide hacktoberfest hacktoberfest ToDo A ToDo list of tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants