-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added one more automated check
to make the codebase better.
#23577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Hi @Sai-Suraj-27, thank you for your contribution! I will have to close your PR as it isn't related to any of the tasks open for contributions that can be found here. With that said, I encourage you to open a feature request issue for this that you could link to another PR if that is of interest. Thanks! |
Hi @nassimberrada sir, As you said I have opened a feature request issue for this clearly describing the benefits and why this is needed. I have also linked this PR to that issue. Can you please re-open this PR and consider looking into it? Thank you so much. |
@Sai-Suraj-27 Apologies for closing your PR too quickly, didn't notice you had linked an issue already! @KareemMAX could you look into this ? I see you've helped merge the first part so you're probably better suited to handle this, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sai-Suraj-27,
Thank you so much. As the diff is quite complex, I'll need to revert your PR and apply the changes in an automated manner before merging.
b090107
to
3c9064b
Compare
automated check
to make the codebase better.
…y-llc#23577) Co-authored-by: Kareem Morsy <[email protected]>
…y-llc#23577) Co-authored-by: Kareem Morsy <[email protected]>
PR Description
Updated the
.pre-commit-config.yaml
file by adding one more check (with automated fix). I found that this check is very common and used in most of the bigPython
based organizations including Paddle, scikit-learn, mindsbd, jax, pandas, etc. Also, modified all the files accordingly by runningpre-commit run --all-files
.Added the following pre-commit hook
end-of-file-fixer makes sure that all files end in a newline and only a newline
It can help to prevent errors, as some programs may rely on the presence of a newline character at the end of a file.
It can help to ensure that files are consistent with each other, as all files in a repository should have the same end-of-file style.
Related Issue
Close #23752
Checklist
Socials: