Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added one more automated check to make the codebase better. #23577

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Sep 14, 2023

PR Description

Updated the .pre-commit-config.yaml file by adding one more check (with automated fix). I found that this check is very common and used in most of the big Python based organizations including Paddle, scikit-learn, mindsbd, jax, pandas, etc. Also, modified all the files accordingly by running pre-commit run --all-files.

Added the following pre-commit hook

  1. end-of-file-fixer (Ensures that files end with a newline character)

end-of-file-fixer makes sure that all files end in a newline and only a newline
It can help to prevent errors, as some programs may rely on the presence of a newline character at the end of a file.
It can help to ensure that files are consistent with each other, as all files in a repository should have the same end-of-file style.

Related Issue

Close #23752

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@ivy-leaves ivy-leaves added the Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards label Sep 14, 2023
@a0m0rajab a0m0rajab modified the milestone: #10388 Sep 14, 2023
@ivy-seed ivy-seed assigned nassimberrada and unassigned D0m-inic Sep 17, 2023
@nassimberrada
Copy link
Contributor

nassimberrada commented Sep 17, 2023

Hi @Sai-Suraj-27, thank you for your contribution! I will have to close your PR as it isn't related to any of the tasks open for contributions that can be found here. With that said, I encourage you to open a feature request issue for this that you could link to another PR if that is of interest. Thanks!

@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Sep 17, 2023

Hi @nassimberrada sir, As you said I have opened a feature request issue for this clearly describing the benefits and why this is needed. I have also linked this PR to that issue. Can you please re-open this PR and consider looking into it? Thank you so much.

@nassimberrada nassimberrada reopened this Sep 17, 2023
@nassimberrada
Copy link
Contributor

@Sai-Suraj-27 Apologies for closing your PR too quickly, didn't notice you had linked an issue already! @KareemMAX could you look into this ? I see you've helped merge the first part so you're probably better suited to handle this, thanks!

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sai-Suraj-27,
Thank you so much. As the diff is quite complex, I'll need to revert your PR and apply the changes in an automated manner before merging.

@KareemMAX KareemMAX merged commit 28e3129 into ivy-llc:main Sep 21, 2023
10 of 11 checks passed
@Sai-Suraj-27 Sai-Suraj-27 changed the title feat: Added one more automated check to make the codebase better. feat: Added one more automated check to make the codebase better. Sep 23, 2023
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add end-of-file-fixer check.
6 participants