-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update set.py #23570
feat: Update set.py #23570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, seems like you have changed docs/demos
which you might have done by mistake. Can you revert that change because we can't merge with that change in place?
@KareemMAX I seem to be having trouble using "git checkout/revert" to revert these changes, I am trying to do it by using a codespace but it does not seem to work. Could i also create a new commit that includes the up to date version of those files that are on the repository (not inlcluding my changes)? |
I guess that should work, also try merging |
353e29e
to
1b08294
Compare
I ended up being able to remove the "docs" changes, is my work ready to merge now? Also, during this process, i accidentally requested 3 other reviewers. @RickSanchezStoic, @sherry30, @CatB1t, sorry about that, are you able to remove yourselves from this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, you have to handle this in the respective test_function
in the test file
aswell and add the functionality there in the hypothesis too.
Thanks!
Hi @zaeemansari70, I have applied these changes now, thanks |
Thank you for this PR, here is the CI results: Failed tests:This PR introduces the following new failing tests: |
Co-authored-by: Carlos Sandoval <[email protected]> Co-authored-by: ivy-branch <[email protected]>
Updated set.py, in particular the unique_inverse function
Close #23539