Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update set.py #23570

Merged
merged 6 commits into from
Oct 4, 2023
Merged

feat: Update set.py #23570

merged 6 commits into from
Oct 4, 2023

Conversation

adlub
Copy link
Contributor

@adlub adlub commented Sep 13, 2023

Updated set.py, in particular the unique_inverse function

Close #23539

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@ivy-leaves ivy-leaves added PaddlePaddle Backend Developing the Paddle Paddle Backend. PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist labels Sep 14, 2023
@a0m0rajab a0m0rajab modified the milestone: #10388 Sep 14, 2023
@adlub adlub changed the title Update set.py feat: Update set.py Sep 14, 2023
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

@adlub
Copy link
Contributor Author

adlub commented Sep 28, 2023

Hi, seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

@KareemMAX I seem to be having trouble using "git checkout/revert" to revert these changes, I am trying to do it by using a codespace but it does not seem to work. Could i also create a new commit that includes the up to date version of those files that are on the repository (not inlcluding my changes)?

@KareemMAX
Copy link
Contributor

Hi, seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

@KareemMAX I seem to be having trouble using "git checkout/revert" to revert these changes, I am trying to do it by using a codespace but it does not seem to work. Could i also create a new commit that includes the up to date version of those files that are on the repository (not including my changes)?

I guess that should work, also try merging

@adlub
Copy link
Contributor Author

adlub commented Sep 29, 2023

Hi, seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

@KareemMAX I seem to be having trouble using "git checkout/revert" to revert these changes, I am trying to do it by using a codespace but it does not seem to work. Could i also create a new commit that includes the up to date version of those files that are on the repository (not including my changes)?

I guess that should work, also try merging

I ended up being able to remove the "docs" changes, is my work ready to merge now? Also, during this process, i accidentally requested 3 other reviewers. @RickSanchezStoic, @sherry30, @CatB1t, sorry about that, are you able to remove yourselves from this?

Copy link
Contributor

@zaeemansari70 zaeemansari70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you have to handle this in the respective test_function in the test file aswell and add the functionality there in the hypothesis too.
Thanks!

@adlub
Copy link
Contributor Author

adlub commented Sep 30, 2023

Hi, you have to handle this in the respective test_function in the test file aswell and add the functionality there in the hypothesis too. Thanks!

Hi @zaeemansari70, I have applied these changes now, thanks

@ivy-seed ivy-seed assigned clsandoval and unassigned zaeemansari70 Oct 1, 2023
@KareemMAX KareemMAX self-requested a review October 2, 2023 12:29
@KareemMAX KareemMAX removed their request for review October 2, 2023 12:29
@clsandoval clsandoval merged commit 0f33aeb into ivy-llc:main Oct 4, 2023
131 of 136 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for this PR, here is the CI results:


Failed tests:

This PR introduces the following new failing tests:
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_diff,paddle
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,numpy
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,jax
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,tensorflow
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,torch
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_count_nonzero,numpy
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_count_nonzero,torch
ivy_tests/test_ivy/test_misc/test_array.py::test_array__neg__,numpy
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_manipulation.py::test_partial_vec_to_tensor,numpy

druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Co-authored-by: Carlos Sandoval <[email protected]>
Co-authored-by: ivy-branch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy Functional API PaddlePaddle Backend Developing the Paddle Paddle Backend. PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unique_inverse
7 participants