Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_alpha_dropout #23025

Closed
wants to merge 7 commits into from
Closed

feature_alpha_dropout #23025

wants to merge 7 commits into from

Conversation

FraBomba6
Copy link
Contributor

Close #21634

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 4, 2023
@FraBomba6
Copy link
Contributor Author

Note
alpha_dropout was added by me here but the computation of the function was wrong so I fixed it with the first commit, then added feature_alpha_dropout

@RickSanchezStoic
Copy link
Contributor

Hi @FraBomba6 can you checkout the error logs in intelligent-tests-pr / run_tests (1) (pull_request) and try fixing them ?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@FraBomba6
Copy link
Contributor Author

@RickSanchezStoic I was generating a wrong sized input for the test to run intelligent-tests-pr / run_tests (1) (pull_request)
Now some errors are still present but regarding types conversions between frameworks I guess

@FraBomba6
Copy link
Contributor Author

@RickSanchezStoic could you please check out this PR?

@FraBomba6
Copy link
Contributor Author

@RickSanchezStoic this PR is still pending

@FraBomba6 FraBomba6 closed this by deleting the head repository Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature_alpha_dropout
3 participants