Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sklearn decisiontree #23007

Closed
wants to merge 17 commits into from
Closed

Sklearn decisiontree #23007

wants to merge 17 commits into from

Conversation

umairjavaid
Copy link
Contributor

PR Description

Related Issue

Close #

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

HaiderSultanArc and others added 9 commits September 4, 2023 19:13
@HaiderSultanArc
Merge branch 'main' into sklearn-decisiontree
30625dd
@HaiderSultanArc
Update _classes.py
b428c52
@umairjavaid
implemented compute partial in tree module
5f27d6f
@umairjavaid
added splitter
2601ef5
@umairjavaid
added splitter
cd87ce9
@umairjavaid
Merge branch 'sklearn-decisiontree' of https://github.com/umairjavaid…
b854c1b 
…/ivy into sklearn-decisiontree
@HaiderSultanArc @umairjavaid
Sklearn Decision Tree (ivy-llc#23349)
37007dc 
Co-authored-by: umairjavaid <[email protected]>
@HaiderSultanArc @umairjavaid
@aibenStunner @p3jitnath @muzakkirhussain011 @AliTarekk @ivy-branch @ShreyanshBardia @vaatsalya123 @Killua7362 @ReneFabricius @dash96 @stalemate1 @JomBarce @NripeshN @KareemMAX @lucasalavapena @Sai-Suraj-27 @sabre-code @RashulChutani @mosesdaudu001 @Mghrabi @AnnaTz @Indraneel99 @fnhirwa @Javeria-Siddique @Kiprop2020 @NiteshK84 @he11owthere @hmahmood24 @Daniel4078 @CatB1t @vismaysur @mobley-trent @Madjid-CH @mohame54 @akshatvishu @MahmoudAshraf97 @YushaArif99 @khethan123 @Aaryan562 @Supremolink81 @MahadShahid8 @Dharshannan @RickSanchezStoic @a0m0rajab
Sklearn decisiontree (ivy-llc#23563)
ed7e8e0 
Co-authored-by: umairjavaid <[email protected]>
Co-authored-by: Gadri Ebenezer <[email protected]>
Co-authored-by: nathzi1505 <[email protected]>
Co-authored-by: muzakkirhussain011 <[email protected]>
Co-authored-by: AliTarekk <[email protected]>
Co-authored-by: ivy-branch <[email protected]>
Co-authored-by: Shreyansh Bardia <[email protected]>
Co-authored-by: Vaatsalya <[email protected]>
Co-authored-by: Akshay <[email protected]>
Co-authored-by: ReneFabricius <[email protected]>
Co-authored-by: Vaibhav Deshpande <[email protected]>
Co-authored-by: Vaibhav Deshpande <[email protected]>
Co-authored-by: Jomer Barcenilla <[email protected]>
Co-authored-by: Nripesh Niketan <[email protected]>
Co-authored-by: Kareem Morsy <[email protected]>
Co-authored-by: Lucas Alava Peña <[email protected]>
Co-authored-by: Sai-Suraj-27 <[email protected]>
Co-authored-by: Sulaiman Mutawalli <[email protected]>
Co-authored-by: RashulChutani <[email protected]>
Co-authored-by: Moses Daudu <[email protected]>
Co-authored-by: Ahmed Hisham <[email protected]>
Co-authored-by: AnnaTz <[email protected]>
Co-authored-by: Indraneel kumar <[email protected]>
Co-authored-by: hirwa-nshuti <[email protected]>
Co-authored-by: Javeria-Siddique <[email protected]>
Co-authored-by: Peter Kiprop <[email protected]>
Co-authored-by: Humza Tareen <[email protected]>
Co-authored-by: Nitesh Kesharwani <[email protected]>
Co-authored-by: Bhushan Srivastava <[email protected]>
Co-authored-by: hmahmood24 <[email protected]>
Co-authored-by: Daniel4078 <[email protected]>
Co-authored-by: Mostafa Hani <[email protected]>
Co-authored-by: Mostafa Hany <[email protected]>
Co-authored-by: Vismay Suramwar <[email protected]>
Co-authored-by: Eddy Oyieko <[email protected]>
Co-authored-by: Madjid Chergui <[email protected]>
Co-authored-by: Mohammed Ayman <[email protected]>
Co-authored-by: akshatvishu <[email protected]>
Co-authored-by: MahmoudAshraf97 <[email protected]>
Co-authored-by: Yusha Arif <[email protected]>
Co-authored-by: KHETHAN <[email protected]>
Co-authored-by: khethan123 <[email protected]>
Co-authored-by: NripeshN <[email protected]>
Co-authored-by: Aaryan562 <[email protected]>
Co-authored-by: Ario Zareinia <[email protected]>
Co-authored-by: MahadShahid8 <[email protected]>
Co-authored-by: Dharshannan Sugunan <[email protected]>
Co-authored-by: RickSanchezStoic <[email protected]>
Co-authored-by: Abdurrahman Rajab <[email protected]>
@HaiderSultanArc
Merge branch 'sklearn-decisiontree-test' into sklearn-decisiontree
06e3adb
github-actions[bot]
github-actions bot reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

vedpatwardhan
vedpatwardhan suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all changes other than the ones in the ivy/frontends/sklearn and the ivy_tests/test_ivy/test_frontends/test_sklearn folders can be reverted as they seem unrelated. Thanks @umairjavaid 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vedpatwardhan vedpatwardhan vedpatwardhan requested changes

@RickSanchezStoic RickSanchezStoic Awaiting requested review from RickSanchezStoic

@KareemMAX KareemMAX Awaiting requested review from KareemMAX

@Aarsh2001 Aarsh2001 Awaiting requested review from Aarsh2001

@fnhirwa fnhirwa Awaiting requested review from fnhirwa

@sherry30 sherry30 Awaiting requested review from sherry30

@CatB1t CatB1t Awaiting requested review from CatB1t

Assignees

@hmahmood24 hmahmood24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umairjavaid @vedpatwardhan @hmahmood24 @HaiderSultanArc