Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logical_xor #22994

Closed
wants to merge 5 commits into from
Closed

logical_xor #22994

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b1bd009
logical_xor
roudik Sep 4, 2023
58745d9
🤖 Lint code
ivy-branch Sep 9, 2023
960fab3
logical_xor
roudik Sep 13, 2023
4b0d4e1
Revert "logical_xor"
roudik Sep 13, 2023
4893b16
Merge branch 'unifyai:main' into main
roudik Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ivy/functional/frontends/torch/tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,10 @@ def logical_not_(self):
def logical_or(self, other):
return torch_frontend.logical_or(self, other)

@with_unsupported_dtypes({"2.0.1 and below": ("bfloat16",)}, "torch")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the tests are failing due to an unsupported dtype not listed here. You could check the tests and add the unsupported dtype here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which tests are failing? To me it shows that only run_test (1) is failing which should be ignored as per the instructions above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by unsupported dtype not listed, do you mean to remove the line 440? where do you want me to add unsupported dtype?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you could check the "run_tests (1)` section of the CI and open up "Determine and Run tests" section to see the failing tests.

def logical_xor(self, other):
return torch_frontend.logical_xor(self, other)

def bitwise_not(self):
return torch_frontend.bitwise_not(self)

Expand Down
38 changes: 38 additions & 0 deletions ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8523,6 +8523,44 @@ def test_torch_tensor_logical_or(
)


# logical_xor
@handle_frontend_method(
class_tree=CLASS_TREE,
init_tree="torch.tensor",
method_name="logical_xor",
dtype_and_x=helpers.dtype_and_values(
available_dtypes=helpers.get_dtypes("valid"),
num_arrays=2,
),
)
def test_torch_tensor_logical_xor(
dtype_and_x,
frontend_method_data,
init_flags,
method_flags,
frontend,
on_device,
backend_fw,
):
input_dtype, x = dtype_and_x
helpers.test_frontend_method(
init_input_dtypes=input_dtype,
backend_to_test=backend_fw,
init_all_as_kwargs_np={
"data": x[0],
},
method_input_dtypes=input_dtype,
method_all_as_kwargs_np={
"other": x[1],
},
frontend_method_data=frontend_method_data,
init_flags=init_flags,
method_flags=method_flags,
frontend=frontend,
on_device=on_device,
)


# long
@handle_frontend_method(
class_tree=CLASS_TREE,
Expand Down
Loading