logical_xor

[roudik]

PR Description

Related Issue

Checklist

• Did you add a function?
• Did you add the tests?
• Did you follow the steps we provided?

Socials:

[github-actions]

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

[roudik]

Hey @bipinKrishnan! Are there any issues with this pull request?

[bipinKrishnan]

Hey @roudik , thanks for the contribution!
It would be great if you could install pre-commit in your system so that the lint tests doesn't fail 🙂

[bipinKrishnan]

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

[roudik]

Dear @bipinKrishnan, confused about whether there is still anything to be fixed as the tests show as passed. We should be able to close this PR then?

[roudik]

@bipinKrishnan ??

[bipinKrishnan]

Seems like the tests are failing due to an unsupported dtype not listed here. You could check the tests and add the unsupported dtype here.

[roudik]

Which tests are failing? To me it shows that only run_test (1) is failing which should be ignored as per the instructions above?

[roudik]

Not sure what you mean by unsupported dtype not listed, do you mean to remove the line 440? where do you want me to add unsupported dtype?

[bipinKrishnan]

Hey, you could check the "run_tests (1)` section of the CI and open up "Determine and Run tests" section to see the failing tests.

[roudik]

Thanks for contributing to Ivy! 😊👏 Here are some of the important points from our Contributing Guidelines 📝: 1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections: - Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️ - New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪 2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧 3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚 Happy coding! 🎉👨‍💻

@bipinKrishnan Doesn't it say above that we can feel free to ignore run_tests? The display_test_results check shows as passed.

[bipinKrishnan]

Hey @roudik, its not like that actually. If you read carefully, you will see that "display_test_results" checks for newly introduced failures, so if you open it and check "New failures introduced" you can see that the tests you added are failing. If you need to look into the details of why its failing, you can check "run_tests (1)" which contains the detailed output/traceback of your test. Hope that makes sense.

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

• docs: correct typo in README
• feat: implement dark mode"
• fix: correct remove button behavior

Linting Errors

• Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
• No subject found

[roudik]

Hey @roudik, its not like that actually. If you read carefully, you will see that "display_test_results" checks for newly introduced failures, so if you open it and check "New failures introduced" you can see that the tests you added are failing. If you need to look into the details of why its failing, you can check "run_tests (1)" which contains the detailed output/traceback of your test. Hope that makes sense.

Dear @bipinKrishnan, now that makes sense, but I am not quite sure about what to add to the line with unsupported_dtypes. The working functions logical_or and logical_and both just use bfloat16, and logical_not doesn't even include the line about unsupported dtypes. I have noticed about the failed test mentioning about uint16, but when I tried adding it to the unsupported_dtypes line [...("bfloat16", "uint16",)...] I got even more errors than before.