Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAGING -> MASTER #4657

Merged
merged 27 commits into from
Feb 1, 2024
Merged

STAGING -> MASTER #4657

merged 27 commits into from
Feb 1, 2024

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    6980076 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    907f82c View commit details
    Browse the repository at this point in the history
  3. Remove TestnetConsensus (#4628)

    This was just an alias for another type.
    NullSoldier committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0f48823 View commit details
    Browse the repository at this point in the history
  4. derives public_address from view_key in build (#4624)

    * derives public_address from view_key in build
    
    UnsignedTransaction.build currently takes both a ViewKey _and_ a PublicAddress
    as inputs
    
    with a couple of small changes we can derive the public address from the view
    key so that we don't need to pass both of them around
    
    this simplifies the signatures for build from TypeScript through napi and into
    Rust
    
    * fixes slow unsigned test
    
    * fixes lint
    hughy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ad8f2e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    411858c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f40bbf8 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. removes publicAddress from build args in fixture (#4632)

    one PR added a fixture, another PR changed the arguments of a function that the
    fixture called
    
    when both PRs merged soon after each other, we ended up with a broken build
    hughy committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    58ae673 View commit details
    Browse the repository at this point in the history
  2. Move RawBlock/Header constructors onto BockChain (#4633)

    This is a move in an effort to delete Strategy.
    NullSoldier committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9917b87 View commit details
    Browse the repository at this point in the history
  3. Changes frost test to use participantB address (#4629)

    * Changes frost test to use participantB address
    
    The goal is to make it explicit in the test that the participants
    all have the same address.
    
    * adding comment
    patnir committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d0a3882 View commit details
    Browse the repository at this point in the history
  4. adds napi binding for UnsignedTransaction.sign (#4635)

    exposing 'sign' on the TypeScript side will be useful in the future for signing
    transactions with pre-computed proofs, and it will be useful now for testing
    hughy committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9a633d8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d233c15 View commit details
    Browse the repository at this point in the history
  6. Move wallet test to wallet.test.ts (#4638)

    This wallet test for createTransaction() was incorrectly in
    transaction.test.slow. It was testing an error as a result of calling
    Wallet.createTransaction().
    NullSoldier committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    30e6243 View commit details
    Browse the repository at this point in the history
  7. updating signing commitment type to be array instead of hashmap to ma…

    …tch types in TS layer (cleaner representation) (#4631)
    jowparks committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d684cf9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3f3f4ce View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    86b39ac View commit details
    Browse the repository at this point in the history
  10. Delete Strategy (#4644)

    This was an old concept that is no longer needed for when Iron Fish was
    a library to build a crypto coin and not a crypto coin itself. The
    conecpts that were here have been moved off and to other models.
    NullSoldier committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    099e3e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    4fef853 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c288bb View commit details
    Browse the repository at this point in the history
  3. Delete networkClass SDK argument (#4645)

    This was used to customize the class that the Network was instantiated
    with. This is no longer necesary as we don't disable the miners reward
    calculation anywhere in any tests.
    NullSoldier committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c8a825d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    92b1516 View commit details
    Browse the repository at this point in the history
  5. replacing pgk with nsk (#4647)

    * replacing pgk with nsk
    
    * updating useunsignedtxfixture to use nsk:
    
    * update unsigned.test.slow.ts
    patnir committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3e38f8b View commit details
    Browse the repository at this point in the history
  6. adding serializable trait to jubjub::Fr (#4649)

    * adding serializable trait to jubjub::Fr
    
    * adds InvalidProofAuthorizingKey
    
    * variable name clean up
    
    * fixing test
    patnir committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    92e19f6 View commit details
    Browse the repository at this point in the history
  7. Rahul/ifl 2146 replace pgk on build with proof authorizing key (#4650)

    * adding invalid authorizing key error
    
    * replacing pgk with proof authorizing key
    
    * updating rust node js layer with proof authorizing key
    
    * variable name clean up
    
    * removing test todo
    
    * build method for raw transaction
    patnir committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9085db3 View commit details
    Browse the repository at this point in the history
  8. updates TrustedDealerKeyPackage to use proofAuthorizingKey (#4651)

    * updates TrustedDealerKeyPackage to use proofAuthorizingKey
    
    we plan to store proofAuthorizingKey (nsk) on each account in the walletDb
    instead of storing proofGenerationKey (ak, nsk)
    
    updates split_secret to return proofAuthorizingKey as part of the
    TrustedDealerKeyPackage instead of proofGenerationKey
    
    propagates changes through napi
    
    * removes unused imports
    
    * uses FrSerializable and hex_key instead of bytes_to_hex
    hughy committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    35bfdbe View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. updates createTrustedDealerKeyPackage to return nsk (#4653)

    RPC returns proofAuthorizingKey (nsk) instead of proofGenerationKey
    hughy committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    bb70ff2 View commit details
    Browse the repository at this point in the history
  2. fixes Bech32Encoder backwards compatibility (#4654)

    we recently released a change that added an optional field to the end of bech32
    account encodings. however, we did not update the encoder to correctly handle
    older encodings that are missing that optional field
    
    if a user attempts to import an older bech32 account they will see an error when
    the Bech32Encoder attempts to read a byte after the end of their import string
    
    updates the Bech32Encoder to support decoding multiple versions:
    - defines 'Bech32Decoder' as a function that takes a reader and decoding options
      and returns an AccountImport
    - adds a mapping to Bech32Encoder that maps supported versions to decode
      functions for those versions
    
    adds a test case for a bech32 account from v1.16.0
    hughy committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9dcf665 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    517e702 View commit details
    Browse the repository at this point in the history