STAGING -> MASTER #4657
Merged
STAGING -> MASTER #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was just an alias for another type.
* derives public_address from view_key in build UnsignedTransaction.build currently takes both a ViewKey _and_ a PublicAddress as inputs with a couple of small changes we can derive the public address from the view key so that we don't need to pass both of them around this simplifies the signatures for build from TypeScript through napi and into Rust * fixes slow unsigned test * fixes lint
one PR added a fixture, another PR changed the arguments of a function that the fixture called when both PRs merged soon after each other, we ended up with a broken build
This is a move in an effort to delete Strategy.
* Changes frost test to use participantB address The goal is to make it explicit in the test that the participants all have the same address. * adding comment
exposing 'sign' on the TypeScript side will be useful in the future for signing transactions with pre-computed proofs, and it will be useful now for testing
This wallet test for createTransaction() was incorrectly in transaction.test.slow. It was testing an error as a result of calling Wallet.createTransaction().
…tch types in TS layer (cleaner representation) (#4631)
This was an old concept that is no longer needed for when Iron Fish was a library to build a crypto coin and not a crypto coin itself. The conecpts that were here have been moved off and to other models.
This was used to customize the class that the Network was instantiated with. This is no longer necesary as we don't disable the miners reward calculation anywhere in any tests.
…t/createSigningShare (#4648)
* replacing pgk with nsk * updating useunsignedtxfixture to use nsk: * update unsigned.test.slow.ts
* adding serializable trait to jubjub::Fr * adds InvalidProofAuthorizingKey * variable name clean up * fixing test
* adding invalid authorizing key error * replacing pgk with proof authorizing key * updating rust node js layer with proof authorizing key * variable name clean up * removing test todo * build method for raw transaction
* updates TrustedDealerKeyPackage to use proofAuthorizingKey we plan to store proofAuthorizingKey (nsk) on each account in the walletDb instead of storing proofGenerationKey (ak, nsk) updates split_secret to return proofAuthorizingKey as part of the TrustedDealerKeyPackage instead of proofGenerationKey propagates changes through napi * removes unused imports * uses FrSerializable and hex_key instead of bytes_to_hex
RPC returns proofAuthorizingKey (nsk) instead of proofGenerationKey
we recently released a change that added an optional field to the end of bech32 account encodings. however, we did not update the encoder to correctly handle older encodings that are missing that optional field if a user attempts to import an older bech32 account they will see an error when the Bech32Encoder attempts to read a byte after the end of their import string updates the Bech32Encoder to support decoding multiple versions: - defines 'Bech32Decoder' as a function that takes a reader and decoding options and returns an AccountImport - adds a mapping to Bech32Encoder that maps supported versions to decode functions for those versions adds a test case for a bech32 account from v1.16.0
NullSoldier
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.