refactor: using error is instead of == [skip changelog]

client/rpc/apifile.go

@@ -3,6 +3,7 @@ package rpc
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 
@@ -94,7 +95,7 @@ func (f *apiFile) ReadAt(p []byte, off int64) (int, error) {
 	defer resp.Output.Close()
 
 	n, err := io.ReadFull(resp.Output, p)
-	if err == io.ErrUnexpectedEOF {
+	if errors.Is(err, io.ErrUnexpectedEOF) {
 		err = io.EOF
 	}
 	return n, err
@@ -170,7 +171,7 @@ func (it *apiIter) Next() bool {
 
 	var out lsOutput
 	if err := it.dec.Decode(&out); err != nil {
-		if err != io.EOF {
+		if !errors.Is(err, io.EOF) {
 			it.err = err
 		}
 		return false

client/rpc/name.go

@@ -3,6 +3,7 @@
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 
@@ -79,7 +80,7 @@
 		for {
 			var out struct{ Path string }
 			err := dec.Decode(&out)
-			if err == io.EOF {
+			if errors.Is(err, io.EOF) {
 				return
 			}
 			var ires iface.IpnsResult

client/rpc/pin.go

@@ -216,7 +216,7 @@ func (api *PinAPI) Verify(ctx context.Context) (<-chan iface.PinStatus, error) {
 				}
 			}
 			if err := dec.Decode(&out); err != nil {
-				if err == io.EOF {
+				if errors.Is(err, io.EOF) {
 					return
 				}
 				select {

client/rpc/pubsub.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"io"
 
 	iface "github.com/ipfs/boxo/coreiface"
@@ -175,7 +176,7 @@ func (api *PubsubAPI) Subscribe(ctx context.Context, topic string, opts ...caopt
 		for {
 			var msg pubsubMessage
 			if err := dec.Decode(&msg); err != nil {
-				if err == io.EOF {
+				if errors.Is(err, io.EOF) {
 					return
 				}
 				msg.err = err

client/rpc/unixfs.go

@@ -162,7 +162,7 @@ func (api *UnixfsAPI) Ls(ctx context.Context, p path.Path, opts ...caopts.Unixfs
 		for {
 			var link lsOutput
 			if err := dec.Decode(&link); err != nil {
-				if err == io.EOF {
+				if errors.Is(err, io.EOF) {
 					return
 				}
 				select {

cmd/ipfs/util/ulimit.go

@@ -82,7 +82,7 @@
 		// set the soft value
 		err = setLimit(targetLimit, hard)
 		if err != nil {
-			err = fmt.Errorf("error setting ulimit without hard limit: %s", err)
+			err = fmt.Errorf("error setting ulimit without hard limit: %w", err)
 			break
 		}
 		newLimit = targetLimit
@@ -107,7 +107,7 @@
 			break
 		}
 	default:
-		err = fmt.Errorf("error setting: ulimit: %s", err)
+		err = fmt.Errorf("error setting: ulimit: %w", err)
 	}
 
 	return newLimit > 0, newLimit, err

config/bootstrap_peers.go

@@ -36,7 +36,7 @@
 func DefaultBootstrapPeers() ([]peer.AddrInfo, error) {
 	ps, err := ParseBootstrapPeers(DefaultBootstrapAddresses)
 	if err != nil {
-		return nil, fmt.Errorf(`failed to parse hardcoded bootstrap peers: %s
+		return nil, fmt.Errorf(`failed to parse hardcoded bootstrap peers: %w
 This is a problem with the ipfs codebase. Please report it to the dev team`, err)
 	}
 	return ps, nil

config/config.go

@@ -117,7 +117,7 @@
 	}
 	var conf Config
 	if err := json.NewDecoder(buf).Decode(&conf); err != nil {
-		return nil, fmt.Errorf("failure to decode config: %s", err)
+		return nil, fmt.Errorf("failure to decode config: %w", err)
 	}
 	return &conf, nil
 }
@@ -129,7 +129,7 @@
 	}
 	var m map[string]interface{}
 	if err := json.NewDecoder(buf).Decode(&m); err != nil {
-		return nil, fmt.Errorf("failure to decode config: %s", err)
+		return nil, fmt.Errorf("failure to decode config: %w", err)
 	}
 	return m, nil
 }
@@ -140,11 +140,11 @@
 	var buf bytes.Buffer
 
 	if err := json.NewEncoder(&buf).Encode(c); err != nil {
-		return nil, fmt.Errorf("failure to encode config: %s", err)
+		return nil, fmt.Errorf("failure to encode config: %w", err)
 	}
 
 	if err := json.NewDecoder(&buf).Decode(&newConfig); err != nil {
-		return nil, fmt.Errorf("failure to decode config: %s", err)
+		return nil, fmt.Errorf("failure to decode config: %w", err)
 	}
 
 	return &newConfig, nil

config/serialize/serialize.go

@@ -28,7 +28,7 @@
 	}
 	defer f.Close()
 	if err := json.NewDecoder(f).Decode(cfg); err != nil {
-		return fmt.Errorf("failure to decode config: %s", err)
+		return fmt.Errorf("failure to decode config: %w", err)
 	}
 	return nil
 }

core/bootstrap/bootstrap.go

@@ -309,7 +309,7 @@
 			log.Debugf("%s bootstrapping to %s", ph.ID(), p.ID)
 
 			if err := ph.Connect(ctx, p); err != nil {
-				if ctx.Err() != context.Canceled {
+				if !errors.Is(ctx.Err(), context.Canceled) {
 					log.Debugf("failed to bootstrap with %v: %s", p.ID, err)
 				}
 				return

repo/fsrepo/fsrepo.go

@@ -449,7 +449,7 @@ func (r *FSRepo) openConfig() error {
 func (r *FSRepo) openUserResourceOverrides() error {
 	// This filepath is documented in docs/libp2p-resource-management.md and be kept in sync.
 	err := serialize.ReadConfigFile(filepath.Join(r.path, "libp2p-resource-limit-overrides.json"), &r.userResourceOverrides)
-	if err == serialize.ErrNotInitialized {
+	if errors.Is(err, serialize.ErrNotInitialized) {
 		err = nil
 	}
 	return err

repo/fsrepo/migrations/httpfetcher.go

@@ -66,7 +66,7 @@
 
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, gwURL, nil)
 	if err != nil {
-		return nil, fmt.Errorf("http.NewRequest error: %s", err)
+		return nil, fmt.Errorf("http.NewRequest error: %w", err)
 	}
 
 	if f.userAgent != "" {
@@ -75,14 +75,14 @@
 
 	resp, err := http.DefaultClient.Do(req)
 	if err != nil {
-		return nil, fmt.Errorf("http.DefaultClient.Do error: %s", err)
+		return nil, fmt.Errorf("http.DefaultClient.Do error: %w", err)
 	}
 
 	if resp.StatusCode >= 400 {
 		defer resp.Body.Close()
 		mes, err := io.ReadAll(resp.Body)
 		if err != nil {
-			return nil, fmt.Errorf("error reading error body: %s", err)
+			return nil, fmt.Errorf("error reading error body: %w", err)
 		}
 		return nil, fmt.Errorf("GET %s error: %s: %s", gwURL, resp.Status, string(mes))
 	}

repo/fsrepo/migrations/migrations.go

@@ -32,7 +32,7 @@
 	}
 	fromVer, err := RepoVersion(ipfsDir)
 	if err != nil {
-		return fmt.Errorf("could not get repo version: %s", err)
+		return fmt.Errorf("could not get repo version: %w", err)
 	}
 	if fromVer == targetVer {
 		// repo already at target version number
@@ -87,7 +87,7 @@
 		logger.Println("Running migration", migration, "...")
 		err = runMigration(ctx, binPaths[migration], ipfsDir, revert, logger)
 		if err != nil {
-			return fmt.Errorf("migration %s failed: %s", migration, err)
+			return fmt.Errorf("migration %s failed: %w", migration, err)
 		}
 	}
 	logger.Printf("Success: fs-repo migrated to version %d.\n", targetVer)
@@ -98,7 +98,7 @@
 func NeedMigration(target int) (bool, error) {
 	vnum, err := RepoVersion("")
 	if err != nil {
-		return false, fmt.Errorf("could not get repo version: %s", err)
+		return false, fmt.Errorf("could not get repo version: %w", err)
 	}
 
 	return vnum != target, nil
@@ -171,7 +171,7 @@
 		default:
 			u, err := url.Parse(src)
 			if err != nil {
-				return nil, fmt.Errorf("bad gateway address: %s", err)
+				return nil, fmt.Errorf("bad gateway address: %w", err)
 			}
 			switch u.Scheme {
 			case "":
@@ -293,7 +293,7 @@
 	if len(fails) != 0 {
 		err = fmt.Errorf("failed to download migrations: %s", strings.Join(fails, " "))
 		if ctx.Err() != nil {
-			err = fmt.Errorf("%s, %s", ctx.Err(), err)
+			err = fmt.Errorf("%s, %w", ctx.Err(), err)
 		}
 		return nil, err
 	}

repo/fsrepo/migrations/versions.go

@@ -57,7 +57,7 @@
 		vers = append(vers, ver)
 	}
 	if scan.Err() != nil {
-		return nil, fmt.Errorf("could not read versions: %s", scan.Err())
+		return nil, fmt.Errorf("could not read versions: %w", scan.Err())
 	}
 
 	if sortDesc {

routing/composer.go

@@ -2,6 +2,7 @@
 
 import (
 	"context"
+	"errors"
 
 	"github.com/hashicorp/go-multierror"
 	"github.com/ipfs/go-cid"
@@ -103,7 +104,7 @@
 	ch, err := c.GetValueRouter.SearchValue(ctx, key, opts...)
 
 	// avoid nil channels on implementations not supporting SearchValue method.
-	if err == routing.ErrNotFound && ch == nil {
+	if errors.Is(err, routing.ErrNotFound) && ch == nil {
 		out := make(chan []byte)
 		close(out)
 		return out, err

tar/format.go

@@ -49,7 +49,7 @@ func ImportTar(ctx context.Context, r io.Reader, ds ipld.DAGService) (*dag.Proto
 	for {
 		h, err := tr.Next()
 		if err != nil {
-			if err == io.EOF {
+			if errors.Is(err, io.EOF) {
 				break
 			}
 			return nil, err
@@ -128,7 +128,7 @@ func (tr *tarReader) Read(b []byte) (int, error) {
 	// no header remaining, check for recursive
 	if tr.childRead != nil {
 		n, err := tr.childRead.Read(b)
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			tr.childRead = nil
 			return n, nil
 		}
@@ -138,7 +138,7 @@ func (tr *tarReader) Read(b []byte) (int, error) {
 	// check for filedata to be read
 	if tr.fileRead != nil {
 		n, err := tr.fileRead.Read(b)
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			nr := tr.fileRead.n
 			tr.pad = (blockSize - (nr % blockSize)) % blockSize
 			tr.fileRead.Close()
@@ -175,7 +175,7 @@ func (tr *tarReader) Read(b []byte) (int, error) {
 	tr.hdrBuf = bytes.NewReader(hndpb.Data())
 
 	dataNd, err := hndpb.GetLinkedProtoNode(tr.ctx, tr.ds, "data")
-	if err != nil && err != dag.ErrLinkNotFound {
+	if err != nil && !errors.Is(err, dag.ErrLinkNotFound) {
 		return 0, err
 	}