refactor: using error is instead of == [skip changelog] #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
requested changes
Aug 22, 2023
There was a problem hiding this comment.
I wont comment on all the occurences, but io.EOF must never be wrapped because it was created before errors.Is and there is way to much code that relies on ==.
errors.Is also generates garbage so we shouldn't use it unless it is realistical to trigger where == would not (so not io.EOF).
Jorropo
reviewed
Aug 22, 2023
|
@Jorropo so, I need to remove all |
|
|
|
@Jorropo its fixed |
|
@Jorropo can you have a review? |
Jorropo
requested changes
Aug 22, 2023
Co-authored-by: Jorropo <[email protected]>
|
@Jorropo donee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
errors.Is()instead of==or!=and also use the%wfor wrapped errors.