Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax dag-cbor error check #205

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: relax dag-cbor error check #205

merged 2 commits into from
Apr 18, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 17, 2024 •
edited
Loading

Thanks for noticing this @SgtPooki, agree we should not care about body, we care about status code.

@lidel
fix: relax dag-cbor error check
927503a 
we should not care about body, we care about status code
@lidel lidel requested review from SgtPooki and hacdias April 17, 2024 14:43
@github-actions GitHub Actions
Copy link
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2049 0 0 0

@lidel lidel mentioned this pull request Apr 17, 2024
Closed
5 tasks
@lidel lidel marked this pull request as ready for review April 17, 2024 14:47
@github-actions GitHub Actions
Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2049 0 0 0

hacdias
hacdias suggested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line in the changelog before merging. Maybe we should add a CI check for that. Otherwise we'll have to go back and write the changelog when we want to release. Other than that, lgtm :)

hacdias
hacdias approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it to the changelog. Merging.

@hacdias hacdias merged commit 41f88f8 into main Apr 18, 2024
11 of 12 checks passed
@hacdias hacdias deleted the fix/relax-dag-cbor-error-check branch April 18, 2024 10:08
@github-actions github-actions bot mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

@hacdias hacdias hacdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidel @SgtPooki @hacdias