Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 0.5.2 #208

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: release 0.5.2 #208

merged 2 commits into from
May 20, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented May 20, 2024

No description provided.

Copy link
Contributor

v0.5.2

Changed

  • Fixed: relaxed dag-cbor error check (#205)
  • Fixed: Header().Has works properly for checking multiple values (#207)

Copy link
Contributor

github-actions bot commented May 20, 2024

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2049 0 0 0

Copy link
Contributor

github-actions bot commented May 20, 2024

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2049 0 0 0

@lidel
Copy link
Member Author

lidel commented May 20, 2024

Ugh, we have "green" CI for "e2e kubo latest|main", but Kubo is failing 9 conformance tests, and only indicator is a number in a comment that people (at least me) are trained (thanks to codecov) to ignore.

I think the problem was introduced in #207, Kubo fails because Kubo sends header more than once (which is allowed in HTTP).

TODO

  • make kubo e2e pass

@lidel lidel marked this pull request as draft May 20, 2024 18:39
@lidel lidel marked this pull request as ready for review May 20, 2024 20:45
@lidel
Copy link
Member Author

lidel commented May 20, 2024

Added normalization in ca15cc8, it saves us headache of having two code paths in every test sugar that has to operate on header values, and allows us to ship v0.5.2 without risk of breaking kubo CI.

@lidel lidel merged commit 26994cf into main May 20, 2024
11 of 12 checks passed
@lidel lidel deleted the release-0.5.2 branch May 20, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant