Define //flags:lnw_version command-line flag #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a --//flags:lnw_version command-line flag that defines the configuration setting //flags:lnw_v2 or //flags:lnw_v3 if the lnw_version is 2 or 3 and the target is ES2K. - Modified krnlmon_cc_library() to define the preprocessor symbol LNW_V2 or LNW_V3 if the corresponding configuration setting is enabled. Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a
--//flags:lnw_versioncommand-line flag that enables the//flags:lnw_v2or//flags:lnw_v3configuration setting iflnw_versionis 2 or 3 and the target is ES2K.Modified
krnlmon_cc_library()to define the preprocessor symbolLNW_V2orLNW_V3if the corresponding configuration setting is enabled.This turned out to be really tricky to do. There's an
int_flag()rule, but I couldn't get it to work. I also ran into difficulties when I tried to limit thelnw_v2andlnw_v3conditionals to ES2K builds.The solution turned out to be (1) write my own rule to use in place of
int_flag(), and (2) use two differentconfig_setting()parameters to and the conditionals. Fortunately, there were fairly good examples of both. The same can not be said forint_flag().This was definitely easier to do in cmake.