Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): change some debug logs to warnings and errors #958

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/nodejs-old/src/message_handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ impl MessageHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(
serde_json::to_string(&Response::Error(e.into()))
.expect("the response is generated manually, so unwrap is safe."),
Expand Down
2 changes: 1 addition & 1 deletion bindings/nodejs/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl ClientMethodHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(format!("Couldn't parse to method with error - {e:?}"), true)
}
}
Expand Down
2 changes: 1 addition & 1 deletion bindings/nodejs/src/secret_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ impl SecretManagerMethodHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(format!("Couldn't parse to method with error - {e:?}"), true)
}
}
Expand Down
2 changes: 1 addition & 1 deletion bindings/nodejs/src/wallet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl WalletMethodHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(
serde_json::to_string(&Response::Error(e.into())).expect("json to string error"),
true,
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/client/api/block_builder/transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ impl<'a> ClientBlockBuilder<'a> {
let conflict = verify_semantic(&prepared_transaction_data.inputs_data, &tx_payload, current_time)?;

if conflict != ConflictReason::None {
log::debug!("[sign_transaction] conflict: {conflict:?} for {:#?}", tx_payload);
log::warn!("[sign_transaction] conflict: {conflict:?} for {:#?}", tx_payload);
return Err(Error::TransactionSemantic(conflict));
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/src/client/node_manager/syncing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ impl ClientInner {
}
}
} else {
log::debug!("{} is not healthy: {:?}", node.url, info);
log::warn!("{} is not healthy: {:?}", node.url, info);
}
}
Err(err) => {
Expand Down
4 changes: 2 additions & 2 deletions sdk/src/client/secret/ledger_nano.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ impl SecretManage for LedgerSecretManager {
}
}
} else {
log::debug!("[LEDGER] unsupported output");
log::warn!("[LEDGER] unsupported output");
return Err(Error::MiscError.into());
}

Expand All @@ -338,7 +338,7 @@ impl SecretManage for LedgerSecretManager {

// was index found?
if remainder_index as usize == essence.outputs().len() {
log::debug!("[LEDGER] remainder_index not found");
log::warn!("[LEDGER] remainder_index not found");
return Err(Error::MiscError.into());
}
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/client/secret/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ where
let conflict = verify_semantic(&inputs_data, &tx_payload, current_time)?;

if conflict != ConflictReason::None {
log::debug!("[sign_transaction] conflict: {conflict:?} for {:#?}", tx_payload);
log::warn!("[sign_transaction] conflict: {conflict:?} for {:#?}", tx_payload);
return Err(Error::TransactionSemantic(conflict));
}

Expand Down
Loading