chore(logging): change some debug logs to warnings and errors #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
There was a problem hiding this comment.
Not sure about the message handlers. Failing to deserialize a message from a client isn't really an error, per-se. It just means the client sent bad data. For devops this could be quite annoying. It's like if we logged an error every time someone sent a bad API request.
Thoralf-M
approved these changes
Jul 28, 2023
thibault-martinez
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Some circumstances were logged as
debug, but they should be logged aswarnor even aserrorin some cases. This makes identifying unusual situations in the log file a bit easier.Links to any relevant issues
Closes #317
Type of change
How the change has been tested
By 🙏 ing!