-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new UX flow for connecting wallet #619
Merged
Merged
Changes from 46 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
1c62f83
feat: use new UX flow for connecting wallet
sidvishnoi 0abbe8e
validation improvements
sidvishnoi b84f142
reset walletAddressInfo on walletAddressUrl change
sidvishnoi 2f89f23
make Amount field readOnly so it's focusable with tab
sidvishnoi 4c1575b
correctly reset walletAddressInfo to null on change
sidvishnoi b4229b3
wip: try basic implementation for keyShare
sidvishnoi fdee425
improvements to ConnectWalletForm UI when key share error
sidvishnoi 073fc64
make key-sharing part of connectWallet
sidvishnoi be29f25
remove keyShare logic from this PR
sidvishnoi 7ed05fa
cleanup, nits
sidvishnoi fcbcfa4
disable submit button by default as Bibi asked
sidvishnoi ec8ef27
fix: try adding key only if not already added
sidvishnoi ae77a5b
cleanup; remove keyShareService from this PR
sidvishnoi f5658b0
extract `allowOnlyNumericInput`
sidvishnoi 89a4bd1
copy updates
sidvishnoi 09a2f4a
move copy to messages.json
sidvishnoi 5492262
add missing copy in messages.json; add some descriptions; nits
sidvishnoi 4f953d6
nit: call setError only if there's an error
sidvishnoi f666a00
update copy: labels
sidvishnoi ca775a2
add errorWithKey helpers
sidvishnoi 50d6e63
Merge branch 'main' into setup-page/new-flow
sidvishnoi c229081
fix(ConnectWalletForm): make amount & recurring toggle inline
sidvishnoi 07c4833
don't hide header when there's errors now that we've more space
sidvishnoi 5bd3dbe
fix isErrorWithKey exception when string or null is passed
sidvishnoi 025dcb9
sync with error-keys PR
sidvishnoi 24f317e
fix: handle error when url doesn't return JSON response
sidvishnoi c88fcc0
update E2E tests
sidvishnoi 17d729e
Merge branch 'main' into setup-page/new-flow
sidvishnoi 9a6e922
fix: update _locales and some usage
sidvishnoi 1fdadd2
refactor: move onBlur handlers to separate functions (allow reuse)
sidvishnoi af2aa7b
default amount to 5.00
sidvishnoi eb84eeb
fix typo in copy
sidvishnoi 8774b2d
remove AutomaticKeyPair notice
sidvishnoi e162711
form layout improvements; prevent scroll when errors/key are shown
sidvishnoi 966016c
perf: useCallback in some places
sidvishnoi 80e42b4
disable spell check on wallet url input
sidvishnoi d84d6ea
use enterkeyhint=go in url input
sidvishnoi 5451a92
Input.tsx: add comment for id use
sidvishnoi eda07cd
provide better interface when pasting url into input
sidvishnoi 3b15f78
fix stray ' in copy
sidvishnoi bbefb8f
better error handling with paste, default (stored) values
sidvishnoi 956eef6
Revert "remove AutomaticKeyPair notice"
sidvishnoi 8506441
replace AutomaticKeyPairNote with Footer; update msg
sidvishnoi 8448aeb
nit
sidvishnoi 1b794cb
update copy to reduce mention of "key"
sidvishnoi 0d2011d
Merge branch 'setup-page/new-flow' of github.com:interledger/web-mone…
sidvishnoi a01c5fd
Merge branch 'main' into setup-page/new-flow
sidvishnoi 6809546
Merge branch 'main' into setup-page/new-flow
sidvishnoi 53f3592
strongly typed PopupTransientState
sidvishnoi 9f08c84
better error handling
sidvishnoi 0d4e508
disable connect button when in progress
sidvishnoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be implemented in follow-up PRs. This PR changes the UI and handles the fallback case where we fail to add key for some reason.