Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new UX flow for connecting wallet #619

Merged
merged 51 commits into from
Sep 26, 2024
Merged

feat: use new UX flow for connecting wallet #619

merged 51 commits into from
Sep 26, 2024

Commits on Sep 20, 2024

  1. feat: use new UX flow for connecting wallet

    @sidvishnoi
    sidvishnoi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1c62f83 View commit details
    Browse the repository at this point in the history

  2. validation improvements

    @sidvishnoi
    sidvishnoi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0abbe8e View commit details
    Browse the repository at this point in the history

  3. reset walletAddressInfo on walletAddressUrl change 

    Code nits
    @sidvishnoi
    sidvishnoi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b84f142 View commit details
    Browse the repository at this point in the history

  4. make Amount field readOnly so it's focusable with tab

    @sidvishnoi
    sidvishnoi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2f89f23 View commit details
    Browse the repository at this point in the history

  5. correctly reset walletAddressInfo to null on change

    @sidvishnoi
    sidvishnoi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4c1575b View commit details
    Browse the repository at this point in the history

  6. wip: try basic implementation for keyShare

    @sidvishnoi
    sidvishnoi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4229b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. improvements to ConnectWalletForm UI when key share error

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fdee425 View commit details
    Browse the repository at this point in the history

  2. make key-sharing part of connectWallet 

    remove ADD_PUBLIC_KEY_TO_WALLET messaging; can be added later if needed
    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    073fc64 View commit details
    Browse the repository at this point in the history

  3. remove keyShare logic from this PR

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    be29f25 View commit details
    Browse the repository at this point in the history

  4. cleanup, nits

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7ed05fa View commit details
    Browse the repository at this point in the history

  5. disable submit button by default as Bibi asked

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fcbcfa4 View commit details
    Browse the repository at this point in the history

  6. fix: try adding key only if not already added 

    fix: continue connect if key add succeeds

code simplification, cleanup
    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ec8ef27 View commit details
    Browse the repository at this point in the history

  7. cleanup; remove keyShareService from this PR 

    remove unnecessary div
more cleanup (try to reduce diff size)
undo some of above cleanup attempts (no benefit of diff size)
    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ae77a5b View commit details
    Browse the repository at this point in the history

  8. extract allowOnlyNumericInput

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f5658b0 View commit details
    Browse the repository at this point in the history

  9. copy updates

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    89a4bd1 View commit details
    Browse the repository at this point in the history

  10. move copy to messages.json

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    09a2f4a View commit details
    Browse the repository at this point in the history

  11. add missing copy in messages.json; add some descriptions; nits

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5492262 View commit details
    Browse the repository at this point in the history

  12. nit: call setError only if there's an error

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4f953d6 View commit details
    Browse the repository at this point in the history

  13. update copy: labels

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f666a00 View commit details
    Browse the repository at this point in the history

  14. add errorWithKey helpers

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ca775a2 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into setup-page/new-flow

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    50d6e63 View commit details
    Browse the repository at this point in the history

  16. fix(ConnectWalletForm): make amount & recurring toggle inline

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c229081 View commit details
    Browse the repository at this point in the history

  17. don't hide header when there's errors now that we've more space

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    07c4833 View commit details
    Browse the repository at this point in the history

  18. fix isErrorWithKey exception when string or null is passed

    @sidvishnoi
    sidvishnoi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5bd3dbe View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. sync with error-keys PR

    @sidvishnoi
    sidvishnoi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    025dcb9 View commit details
    Browse the repository at this point in the history

  2. fix: handle error when url doesn't return JSON response

    @sidvishnoi
    sidvishnoi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    24f317e View commit details
    Browse the repository at this point in the history

  3. update E2E tests

    @sidvishnoi
    sidvishnoi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c88fcc0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into setup-page/new-flow

    @sidvishnoi
    sidvishnoi authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    17d729e View commit details
    Browse the repository at this point in the history

  5. fix: update _locales and some usage

    @sidvishnoi
    sidvishnoi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9a6e922 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. refactor: move onBlur handlers to separate functions (allow reuse)

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1fdadd2 View commit details
    Browse the repository at this point in the history

  2. default amount to 5.00

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    af2aa7b View commit details
    Browse the repository at this point in the history

  3. fix typo in copy

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eb84eeb View commit details
    Browse the repository at this point in the history

  4. remove AutomaticKeyPair notice

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8774b2d View commit details
    Browse the repository at this point in the history

  5. form layout improvements; prevent scroll when errors/key are shown

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e162711 View commit details
    Browse the repository at this point in the history

  6. perf: useCallback in some places

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    966016c View commit details
    Browse the repository at this point in the history

  7. disable spell check on wallet url input

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    80e42b4 View commit details
    Browse the repository at this point in the history

  8. use enterkeyhint=go in url input

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d84d6ea View commit details
    Browse the repository at this point in the history

  9. Input.tsx: add comment for id use

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5451a92 View commit details
    Browse the repository at this point in the history

  10. provide better interface when pasting url into input 

    (don't wait for blur)
    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eda07cd View commit details
    Browse the repository at this point in the history

  11. fix stray ' in copy

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3b15f78 View commit details
    Browse the repository at this point in the history

  12. better error handling with paste, default (stored) values

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bbefb8f View commit details
    Browse the repository at this point in the history

  13. Revert "remove AutomaticKeyPair notice" 

    This reverts commit 8774b2d.
    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    956eef6 View commit details
    Browse the repository at this point in the history

  14. replace AutomaticKeyPairNote with Footer; update msg

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8506441 View commit details
    Browse the repository at this point in the history

  15. nit

    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8448aeb View commit details
    Browse the repository at this point in the history

  16. update copy to reduce mention of "key"

    @sidvishnoi
    sidvishnoi authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1b794cb View commit details
    Browse the repository at this point in the history

  17. Merge branch 'setup-page/new-flow' of github.com:interledger/web-mone… 

    …tization-extension into setup-page/new-flow
    @sidvishnoi
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0d2011d View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into setup-page/new-flow

    @sidvishnoi
    sidvishnoi authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a01c5fd View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'main' into setup-page/new-flow

    @sidvishnoi
    sidvishnoi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6809546 View commit details
    Browse the repository at this point in the history

  2. strongly typed PopupTransientState

    @sidvishnoi
    sidvishnoi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    53f3592 View commit details
    Browse the repository at this point in the history

  3. better error handling

    @sidvishnoi
    sidvishnoi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9f08c84 View commit details
    Browse the repository at this point in the history

  4. disable connect button when in progress

    @sidvishnoi
    sidvishnoi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0d4e508 View commit details
    Browse the repository at this point in the history