Fix clang build fail #168
Fix clang build fail #168
Conversation
|
@yuhaoth I think it is ok. Commit message is also fine. |
|
@yuhaoth emailed about copy rights issues (and suggestions) cc-ing Greg-san. I'd like to avoid confusing users until the situation is settled. |
yuhaoth
force-pushed
the
pr/re-org-clang-apple-patch
branch
2 times, most recently
from
d9a36d7
to
506bfaf
Compare
include/aarch64_multibinary.h
Outdated
|
|
||
| #elif defined(__APPLE__) | ||
| int _get_cpu_capabilities(void); | ||
| #define kHasICDSBShift 2 |
There was a problem hiding this comment.
This part looks same with the code in https://opensource.apple.com/source/xnu/xnu-6153.81.5/osfmk/arm/cpu_capabilities.h.auto.html .
It is release under http://www.opensource.apple.com/apsl/ .
I am not sure if it is conflict with BSD license .
@gbtucker please review .
|
This PR pass at https://travis-ci.org/github/yuhaoth/isa-l/builds/748306963 latest update is to remove some local tag in commit message :) |
|
|
Author of this patch is Taiju Yamada <[email protected]> Re-organized by Jerry Yu <[email protected]> Clang version must be later than 9.x according to https://reviews.llvm.org/D61719 Change-Id: I7516cca17ef4556b828fb6ecfa755e6451052359 Signed-off-by: Jerry Yu <[email protected]>
yuhaoth
force-pushed
the
pr/re-org-clang-apple-patch
branch
from
506bfaf
to
bc8b2ae
Compare
|
Apple support has been removed . @gbtucker please review |
|
it is passed at https://travis-ci.org/github/yuhaoth/isa-l/builds/748495536 |
|
Thanks @yuhaoth and @cielavenir for working together and separating out the clang issue from other. I can schedule this part for integration and leave the other as WIP for now. |
@cielavenir, I re-org your commits . Please review that. I think your patches have two topics
I am not sure if you think it is reasonable to merge this PR and abandon #162 and #164 ?
If No, Could you re-org your patches ?
@gbtucker , please review
include/aarch64_multibinary.h. I am not sure if there are copy rights issues