-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pre-commit config #3194
Conversation
fdad510
to
01a0922
Compare
Ugh, this is another one that can't be merged because of the checks. I'll probably pull it into the SBOM PR for the week and try to work on improving the workflow later. |
Testing the close/open hack on this PR. Looks like this PR may cause issues. |
Codecov Report
@@ Coverage Diff @@
## main #3194 +/- ##
==========================================
+ Coverage 81.43% 81.47% +0.04%
==========================================
Files 716 716
Lines 11116 11126 +10
Branches 1495 1495
==========================================
+ Hits 9052 9065 +13
+ Misses 1683 1680 -3
Partials 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fails on flake8:
cve_bin_tool/cvedb.py:642:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
test/test_checkers.py:[32](https://github.com/intel/cve-bin-tool/actions/runs/5753663775/job/15597350652?pr=3194#step:7:33):16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
test/test_checkers.py:33:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
test/test_checkers.py:34:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
test/test_checkers.py:35:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
test/test_checkers.py:36:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
I'm guessing these should be relatively easy; I might get to them today.
I clearly never got back to this. I'm going to open a beginner-friendly issue to replace this PR with one that updates the pre-commit config and fixes the issues found, but I'm going to close this since I can't use it as is. |
Automated changes by create-pull-request GitHub action