-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option helper for AutoConfigure #525
Option helper for AutoConfigure #525
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 73.21% 73.35% +0.14%
==========================================
Files 80 81 +1
Lines 5073 5104 +31
==========================================
+ Hits 3714 3744 +30
- Misses 1216 1217 +1
Partials 143 143 ☔ View full report in Codecov by Sentry. |
de3c46c
to
05f007c
Compare
77bb6b9
to
1192794
Compare
Ready for review |
1192794
to
fc4ddce
Compare
I have changed the AutoConfigure() helper to return (value, bool) instead of (value, error). I do need this one for coredhcp. Please could you kick off the CI, and if it's happy, I'm good to merge this now. |
Signed-off-by: Brian Candler <[email protected]>
eea957f
to
a052884
Compare
This isn't really a fully-fledged pull request: I'm seeking advice on how best to expose the option AutoConfigure from RFC 2563.
What the proposed patch does is implement a Byte option, based on Uint16 from
dhcpv4/option_maximum_dhcp_message_size.go
However, other possibilities would be:
OptClientIdentifier()
indhcpv4/option_misc.go
Based on the registry, some other examples of single-byte DHCP options are: