Add option IPv6OnlyPreferred (RFC 8925) #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
+ Coverage 73.07% 73.21% +0.13%
==========================================
Files 80 80
Lines 5059 5073 +14
==========================================
+ Hits 3697 3714 +17
+ Misses 1219 1216 -3
Partials 143 143 ☔ View full report in Codecov by Sentry. |
|
Don't you want to add parsing for this option as well to avoid having to deal with |
candlerb
force-pushed
the
candlerb/option108
branch
from
e12c177
to
ca1a9bd
Compare
|
Good point. Helpers added, and tested with a corresponding patched coredhcp. |
candlerb
force-pushed
the
candlerb/option108
branch
from
ca1a9bd
to
82677f5
Compare
hugelgupf
reviewed
Feb 26, 2024
candlerb
force-pushed
the
candlerb/option108
branch
2 times, most recently
from
b6b3db4
to
b6525ca
Compare
|
I think this is in shape for a recheck now, thanks. |
pmazzini
reviewed
Feb 26, 2024
pmazzini
reviewed
Feb 26, 2024
candlerb
force-pushed
the
candlerb/option108
branch
2 times, most recently
from
784988f
to
15306f9
Compare
Signed-off-by: Brian Candler <[email protected]>
candlerb
force-pushed
the
candlerb/option108
branch
from
15306f9
to
fb14ecd
Compare
|
Many thanks. I'm good for you to merge this, and #525. |
pmazzini
approved these changes
Feb 27, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DHCP option is needed to support coredhcp/coredhcp#170