-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearranging modules in the Tendermint spec #1023
Conversation
Not sure why |
Probably because of this: #949 (reply in thread) I'll try it with my local change and see if it fixes the problem |
Unrelated: I'm not getting syntax hightlightning in the added files. Seems like our global config mapping |
My fix makes it so |
Ok, I found the problem but don't know the fix won't be super easy. The problem here is with flattening and constants. In So it is copying I'll probably need to implement some visibility sensitiveness in the flattener as well. The other option is implementing the new flattener I mentioned in the beginning of the week, which will only flatten actually used definitions - that should fix the problem because, if the name resolver passed, then no |
As far as I understand, By the way, I had to do |
I just noticed we don't support |
@konnov I hope you don't mind, I've taken this over a bit to test it with the new flattener - and it works 😄 I just had to add some type annotations for the stuff I tried to run. One thing that is not working is unit tests. It's the same problem I just fixed for verify: since the tests are not used (as far as the flattener knows), they are not copied to the main module and then the test runner finds no tests. I'm looking for a solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really cool!
Refactoring the Tendermint spec a bit. Imports and exports do not seem to work as expected.
Update: imports and exports work with the new flattening, so we're finally opening this PR