Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile only modules that are dependencies of the main module #731

Closed
bugarela opened this issue Mar 22, 2023 · 3 comments
Closed

Compile only modules that are dependencies of the main module #731

bugarela opened this issue Mar 22, 2023 · 3 comments
Labels
simulator Quint simulator

Comments

@bugarela
Copy link
Collaborator

#725 (comment)

Depends on #129

@bugarela bugarela added the simulator Quint simulator label Mar 22, 2023
@bugarela bugarela mentioned this issue Mar 24, 2023
5 tasks
@konnov
Copy link
Contributor

konnov commented Jul 7, 2023

Having #1008 merged, it is relatively easy to implement this feature. We could go even further and prune unused definitions. However, one thing that worries me is that we would miss definitions that otherwise could produce compile-time errors.

What is our concern here? Is it performance or something else?

@bugarela
Copy link
Collaborator Author

bugarela commented Jul 10, 2023

You're the one who brought this up: #725 (comment) 😄

But I believe it mainly affects performance.

This is related to what I mentioned here #1023 (comment). I might rewrite the flattener so it only copies actually used definitions.

one thing that worries me is that we would miss definitions that otherwise could produce compile-time errors.

But that's a good thing, right? Runtime errors should only occur when runtime reaches that branch, and compile-time errors should all be caught by static analysis (which runs before the flattener).

@bugarela
Copy link
Collaborator Author

bugarela commented Oct 4, 2023

Done by the new flattener

@bugarela bugarela closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simulator Quint simulator
Projects
None yet
Development

No branches or pull requests

2 participants