IHMC Commons Release Changes #439
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaszTB
commented
Oct 31, 2024
| boolean includeThreadNumberInName = true; | ||
| return ThreadTools.createNamedThreadFactory(prefix, includePoolInName, includeThreadNumberInName, daemon, Thread.NORM_PRIORITY); | ||
| } | ||
|
|
||
| public static ResettableExceptionHandlingExecutorService newSingleThreadExecutor(String prefix) |
There was a problem hiding this comment.
I didn't move the ResettableExceptionHandlingExecutorService stuff because the class says that it's WIP
ihmc-java-toolkit/src/main/java/us/ihmc/tools/thread/Throttler.java
Outdated
Show resolved
Hide resolved
calvertdw
approved these changes
Oct 31, 2024
ds58
approved these changes
Oct 31, 2024
TomaszTB
changed the title
This was referenced Nov 7, 2024
Merged
TomaszTB
force-pushed
the
migrate-missing-thread-tools
branch
from
d3838ee
to
a21f80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ihmcrobotics/ihmc-commons#33, ihmcrobotics/ihmc-commons#35, ihmcrobotics/ihmc-commons#36