-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Feature/wbcc separate thread #380
Open
Beomyeong
wants to merge
63
commits into
develop
Choose a base branch
from
feature/wbcc-separate-thread
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrolThread to wholebodycontrollerThread
Actually, the outputProcess is moved to "new" thread
Nothing happen yet.
…BodyControllerCoreThread
The output of the wholebodycontrollercore is calculated from controllerThread and saved into contextData. The output of the wholebodycontrollercore is updated to the joint on the wholebodycontrollercorethread.
…he wholebody controllercore between the wholebodycontrollercore thread and controllerThread.
This might be eliminated from moving wholebodyControllerCore into New thread. Also, some state just return the null in this method.
…ext and related classes.
…ontrollerCoreThread.
…ntrollerCoreManager`. Adding the ceterOfMassStateProvider into `HumanoidWholeBodyControllerCoreManager`.
… its implementations
… its implementations
The controllerCoreCommand should be saved to some parameter which can be called in highlevelmanager.
…namics. At the first tick, the commandDataHolder is null.
Only the lowlevelOneDoFJointDesiredDataHolder is used.
…RobotContextDataWholeBodyControllerCore. This lets the ControllerCoreOutput from wholebodycontrollercoreThread be shared to controllerThread.
…d to controlThread.
… the ResolveMomentumRateModule in the ControlThread
Beomyeong
changed the title
Feature/wbcc separate thread
[WIP]Feature/wbcc separate thread
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] work for separating WholeBodyControllerCoreThread (ControllerCoreThread)
The controllerCore.compute which was used and called in the control thread is moved and called in the new
AvatarWholeBodyControllerCoreThread
.Not all the highlevelcontorllerstates use wholebodycontrollerCore to obtain the desiredJointOutput. Also, some highlevelControlState does not use multi-threading even they call the wholebodycontrollerCore. These should be considered when separating wholebodycontrollercore to new thread.
Because, in the older way, the joinDesiredOutput is updated from controlThread,but it changed to be updated on the wholebodycontrollercorethread.
All the changes for now have been focused to change the walkingcontrollerstate first.