Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to using cmake on cross-compiles #454

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Default to using cmake on cross-compiles #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions closed/autoconf/custom-hook.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,7 @@ AC_DEFUN([OPENJ9_CONFIGURE_CMAKE],
[
case "$OPENJ9_PLATFORM_CODE" in
ap64|oa64|or64|wa64|xa64|xl64|xr64|xz64)
if test "x$COMPILE_TYPE" != xcross ; then
with_cmake=cmake
else
with_cmake=no
fi
with_cmake=cmake
;;
*)
with_cmake=no
Copy link
Member

@pshipton pshipton Jun 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the change actually affects anything, since all the platforms already use cmake (at least in project builds). Shouldn't the default change to cmake as well?

Expand Down