Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using cmake on cross-compiles #454

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

dnakamura
Copy link
Contributor

@dnakamura dnakamura commented Jun 7, 2022

Issue #422

Signed-off-by: Devin Nakamura [email protected]

@pshipton
Copy link
Member

pshipton commented Jun 7, 2022

Will this be added to older versions as well?

@pshipton pshipton merged commit 5ccabad into ibmruntimes:openj9 Jun 7, 2022
else
with_cmake=no
fi
with_cmake=cmake
;;
*)
with_cmake=no
Copy link
Member

@pshipton pshipton Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the change actually affects anything, since all the platforms already use cmake (at least in project builds). Shouldn't the default change to cmake as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants