Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSP Queue handling improvements #2048

Merged
merged 12 commits into from
Apr 27, 2024
Merged

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Apr 27, 2024

Changes:

  • attempt ot optimize polling frequency replaced with simple deduplication
  • MSP statistics available in debug console
  • Drop ratio and related PID Controller removed
  • Fixed serial port locking for wireless mode
  • various minor changes

@DzikuVx DzikuVx added this to the 8.0 milestone Apr 27, 2024
@DzikuVx DzikuVx merged commit 04f4b92 into master Apr 27, 2024
3 checks passed
@DzikuVx DzikuVx deleted the dzikuvx-mps-queue-improvements branch April 27, 2024 20:21
@breadoven
Copy link
Collaborator

breadoven commented Apr 28, 2024

I'm not able to open the CLI or Firmware flasher any more, Console is showing the following errors so I'm guessing it's related to this change:

node:internal/modules/cjs/loader:1084 Uncaught Error: Cannot find module './msp/mspDeduplicationQueue'
Require stack:
- F:\INAVDev\inav-configurator\tabs\cli.js
- F:\INAVDev\inav-configurator\js\configurator_main.js
- F:\INAVDev\inav-configurator\index.html
    at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
    at o._resolveFilename (node:electron/js2c/renderer_init:2:3225)
    at Module._load (node:internal/modules/cjs/loader:929:27)
    at l._load (node:electron/js2c/asar_bundle:2:13642)
    at o._load (node:electron/js2c/renderer_init:2:2455)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (F:\INAVDev\inav-configurator\tabs\cli.js:17:31)
    at Object.<anonymous> (F:\INAVDev\inav-configurator\tabs\cli.js:549:3)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
Module._resolveFilename @ node:internal/modules/cjs/loader:1084
o._resolveFilename @ node:electron/js2c/renderer_init:2
Module._load @ node:internal/modules/cjs/loader:929
l._load @ node:electron/js2c/asar_bundle:2
o._load @ node:electron/js2c/renderer_init:2
Module.require @ node:internal/modules/cjs/loader:1150
require @ node:internal/modules/cjs/helpers:119
(anonymous) @ F:\INAVDev\inav-configurator\tabs\cli.js:17
(anonymous) @ F:\INAVDev\inav-configurator\tabs\cli.js:549
Module._compile @ node:internal/modules/cjs/loader:1271
Module._extensions..js @ node:internal/modules/cjs/loader:1326
Module.load @ node:internal/modules/cjs/loader:1126
Module._load @ node:internal/modules/cjs/loader:967
l._load @ node:electron/js2c/asar_bundle:2
o._load @ node:electron/js2c/renderer_init:2
Module.require @ node:internal/modules/cjs/loader:1150
require @ node:internal/modules/cjs/helpers:119
(anonymous) @ F:\INAVDev\inav-configurator\js\configurator_main.js:276
TABS.setup.cleanup @ F:\INAVDev\inav-configurator\tabs\setup.js:308
GUI_control.tab_switch_cleanup @ F:\INAVDev\inav-configurator\js\gui.js:98
(anonymous) @ F:\INAVDev\inav-configurator\js\configurator_main.js:152
dispatch @ F:\INAVDev\inav-configurator\node_modules\jquery\dist\jquery.js:5145
elemData.handle @ F:\INAVDev\inav-configurator\node_modules\jquery\dist\jquery.js:4949

F:\INAVDev\inav-configurator\js\configurator_main.js:36 Uncaught Error: Cannot find module './msp/mspDeduplicationQueue'
Require stack:
- F:\INAVDev\inav-configurator\tabs\cli.js
- F:\INAVDev\inav-configurator\js\configurator_main.js
- F:\INAVDev\inav-configurator\index.html
    at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
    at o._resolveFilename (node:electron/js2c/renderer_init:2:3225)
    at Module._load (node:internal/modules/cjs/loader:929:27)
    at l._load (node:electron/js2c/asar_bundle:2:13642)
    at o._load (node:electron/js2c/renderer_init:2:2455)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (F:\INAVDev\inav-configurator\tabs\cli.js:17:31)
    at Object.<anonymous> (F:\INAVDev\inav-configurator\tabs\cli.js:549:3)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)

@breadoven
Copy link
Collaborator

OK the reference in cli.js and firmware_flasher.js is slightly wrong. Changing to the following seems to fix it:

const mspDeduplicationQueue = require('./../js/msp/mspDeduplicationQueue');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants