Miscellaneous changes to keep up to date with the cookiecutter #6818
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
reviewed
Oct 31, 2024
| @@ -0,0 +1 @@ | |||
| h_testkit | |||
There was a problem hiding this comment.
Suggested change
| h_testkit | |
| h-testkit |
Should be h-testkit I think, but why is this needed in dev.in? The cookiecutter will automatically add this to tests.in and functests.in
There was a problem hiding this comment.
Ah, it looks like they are both equivalent:
https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization
Change it over the - version for consistency 👍
We added this to dev because make shell depends on it
seanh
approved these changes
Oct 31, 2024
marcospri
force-pushed
the
cookie-cutter-updates
branch
from
7972461
to
4c980d2
Compare
- Missing requirements - Environment variables in tox.ini - New programs in supervisor
marcospri
force-pushed
the
cookie-cutter-updates
branch
from
4c980d2
to
0add8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not included: