Skip to content

Commit

Permalink
Miscellaneous changes to keep up to date with the cookiecutter
Browse files Browse the repository at this point in the history
- Missing requirements
- Environment variables in tox.ini
- New programs in supervisor
  • Loading branch information
marcospri committed Nov 5, 2024
1 parent 0765b53 commit 0add8a1
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 5 deletions.
5 changes: 4 additions & 1 deletion .cookiecutter/includes/conf/supervisord-dev.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@
"worker": {
"command": "newrelic-admin run-program celery -A lms.tasks.celery:app worker --loglevel=INFO"
},
"worker-email-digests": {
"command": "newrelic-admin run-program celery -A lms.tasks.celery:app worker --loglevel=INFO -Q email_digests -n celery-email_digests-@%%h"
},
"assets": {
"command": "node_modules/.bin/gulp watch"
}
}
}
}
5 changes: 4 additions & 1 deletion .cookiecutter/includes/conf/supervisord.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
},
"worker": {
"command": "newrelic-admin run-program celery -A lms.tasks.celery:app worker --loglevel INFO"
},
"worker-email-digests": {
"command": "newrelic-admin run-program celery -A lms.tasks.celery:app worker --loglevel INFO -Q email_digests -n celery-email_digests-@%%h"
}
}
}
}
1 change: 1 addition & 0 deletions .cookiecutter/includes/requirements/dev.in
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
h-testkit
1 change: 1 addition & 0 deletions .cookiecutter/includes/requirements/prod.in
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ h-assets
sentry-sdk
h-pyramid-sentry
h-vialib
hubspot-api-client
importlib_resources
mailchimp-transactional
marshmallow
Expand Down
2 changes: 2 additions & 0 deletions .cookiecutter/includes/tox/passenv
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ dev: JSTOR_API_SECRET
dev: DISABLE_KEY_ROTATION
dev: EMAIL_PREFERENCES_SECRET
dev: ADMIN_USERS
dev: HUBSPOT_API_KEY
dev: HUBSPOT_ACCOUNT_ID
1 change: 1 addition & 0 deletions .cookiecutter/includes/tox/setenv
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dev: OAUTH2_STATE_SECRET = {env:OAUTH2_STATE_SECRET:notasecret}
dev: RPC_ALLOWED_ORIGINS = {env:RPC_ALLOWED_ORIGINS:http://localhost:5000}
dev: VIA_URL = {env:VIA_URL:http://localhost:9083}
dev: SESSION_COOKIE_SECRET = {env:SESSION_COOKIE_SECRET:notasecret}
dev: DISABLE_KEY_ROTATION=1
VIA_SECRET = not_a_secret
FDW_USERS = {env:FDW_USERS:report-fdw}
HTTP_HOST = {env:HTTP_HOST:localhost:8001}
Expand Down
1 change: 0 additions & 1 deletion conf/supervisord-dev.conf
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ stderr_events_enabled=true
stopsignal=KILL
stopasgroup=true


[program:assets]
command=node_modules/.bin/gulp watch
stdout_events_enabled=true
Expand Down
2 changes: 1 addition & 1 deletion requirements/dev.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ pip-sync-faster
factory-boy
pyramid-ipython
supervisor
h_testkit
h-testkit
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ skip_install = true
setenv =
PYTHONUNBUFFERED = 1
OBJC_DISABLE_INITIALIZE_FORK_SAFETY = YES
dev: DISABLE_KEY_ROTATION=1
dev: DEV = {env:DEV:true}
dev: SENTRY_ENVIRONMENT = {env:SENTRY_ENVIRONMENT:dev}
dev: NEW_RELIC_APP_NAME = {env:NEW_RELIC_APP_NAME:lms}
Expand Down Expand Up @@ -42,6 +41,7 @@ setenv =
dev: RPC_ALLOWED_ORIGINS = {env:RPC_ALLOWED_ORIGINS:http://localhost:5000}
dev: VIA_URL = {env:VIA_URL:http://localhost:9083}
dev: SESSION_COOKIE_SECRET = {env:SESSION_COOKIE_SECRET:notasecret}
dev: DISABLE_KEY_ROTATION=1
VIA_SECRET = not_a_secret
FDW_USERS = {env:FDW_USERS:report-fdw}
HTTP_HOST = {env:HTTP_HOST:localhost:8001}
Expand Down

0 comments on commit 0add8a1

Please sign in to comment.