Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty author in SmalltalkCIPharo13 #656

Merged
merged 12 commits into from
Aug 28, 2024
Merged

Use empty author in SmalltalkCIPharo13 #656

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
233b8d3
Updated changes because 'Pharo version control should not be used to …
Aug 26, 2024
2800576
Trigger PR update
Aug 26, 2024
807a979
Use at: with a nil check instead of at:ifAbsent: because 'it is not p…
hernanmd Aug 27, 2024
7625c78
Dispatch ignorePackageNotificationClass through SmalltalkCI platformC…
Aug 27, 2024
73b27a5
Merge branch 'hpi-swa:master' into do_not_use_author_in_P13
hernanmd Aug 27, 2024
e4c6739
Try using includesKey: instead of (at:) ifNil:
Aug 27, 2024
e515bb3
I think we don't need the P13 version of ignorePackageNotificationClass
Aug 27, 2024
7e3bce0
Avoid the mess of using Notification and re-introduce MetacelloIgnore…
Aug 28, 2024
92f5df5
Add missing README.md
Aug 28, 2024
af33caf
Add method to ignore author behavior in P13 but keeping compatibility…
Aug 28, 2024
6c1f844
Fix inconsistency in method extension name
Aug 28, 2024
e43b3c7
Try inconsistency fix again
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...itory/SmalltalkCI-Core.package/SCIMetacelloLoadSpec.class/instance/basicLoadProjectOn..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ basicLoadProjectOn: aSmalltalkCI
self withExceptionHandlerDo: [
aSmalltalkCI performMetacelloLoad: [
[ metacello load: self load ]
on: MetacelloIgnorePackageLoaded
on: self ignorePackageNotificationClass
do: [ :e | e resume: self ignoreImage ] ] ]
6 changes: 6 additions & 0 deletions ...talkCI-Core.package/SCIMetacelloLoadSpec.class/instance/ignorePackageNotificationClass.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
executing
ignorePackageNotificationClass
hernanmd marked this conversation as resolved.
Show resolved Hide resolved

^ (Smalltalk globals
at: #MetacelloIgnorePackageLoaded)
ifNil: [ Notification ]
3 changes: 3 additions & 0 deletions repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/ensureAuthor.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
helpers
ensureAuthor
"Do nothing, as Author was removed in Pharo 13"
6 changes: 6 additions & 0 deletions repository/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo13.class/class/getAuthor.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
helpers
getAuthor
"Answer a <String> representing an 'Author' in the image.
Here we answer an empty string since Author support was removed in Pharo 13"

^ ''
5 changes: 5 additions & 0 deletions ...I-Pharo-Tests.package/SmalltalkCIPharoTest.class/instance/testAuthorIsEmptyFromPharo13.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
tests
testAuthorIsEmptyFromPharo13

SmalltalkCI platformClass = SmalltalkCIPharo13
ifTrue: [ self assertEmpty: SmalltalkCI platformClass getAuthor ]
Loading