Use empty author in SmalltalkCIPharo13 #656

hernanmd · 2024-08-21T20:55:12Z

This PR tries to fix #655.
Include a silly test.

hernanmd · 2024-08-21T20:58:42Z

There is a failing job but it seems unrelated: https://github.com/hpi-swa/smalltalkCI/actions/runs/10497340835/job/29079967207?pr=656
@theseion or @fniephaus what do you think?

theseion · 2024-08-22T05:24:54Z

The error is due to a missing file. Unfortunately, you can't simply save changes from Pharo, since the format that Pharo writes can break SmalltalkCI for other / older platforms. I usually make the changes, and then manually replicate them with a text editor. It's not great but it ensures that other builds don't break.

hernanmd · 2024-08-22T09:15:38Z

The error is due to a missing file. Unfortunately, you can't simply save changes from Pharo, since the format that Pharo writes can break SmalltalkCI for other / older platforms. I usually make the changes, and then manually replicate them with a text editor. It's not great but it ensures that other builds don't break.

I understand, and I was commenting about the error that belongs to the Pharo32-3.0 image. That error was also present in previous PR builds: https://github.com/hpi-swa/smalltalkCI/pull/652/checks so that is why I wrote it is not related.

What we would like is to have the Pharo CI green again, without the need to re-introduce the Author class. So it is a request for review :)

theseion · 2024-08-23T05:46:44Z

Put back the version file to repository/SmalltalkCI-Pharo-Core.package/monticello.meta/version with the following contents:

(name 'SmalltalkCI-Pharo-Core-GOC.1683882129' message 'Fix deprecated messages in Pharo 10/11' id 'b9ca235c-bcb8-0d00-8a02-52740b2d30c2' date '23 May 2023' time '8:23:56.450782 am' author 'GOC' ancestors ((name 'SmalltalkCI-Pharo-Core-CompatibleUserName.1683882128' message 'Override isHeadless as mentioned in issue #561.
' id '61a4d773-e6dd-5997-b177-27b70e42f224' date '12 May 2023' time '6:02:08 am' author 'CompatibleUserName' ancestors () stepChildren ())) stepChildren ())

theseion

Looks good. If you put back the version file as well, the build should also become green again.

theseion · 2024-08-24T06:08:43Z

repository/SmalltalkCI-Pharo-Tests.package/monticello.meta/version is also missing:

(name 'SmalltalkCI-Pharo-Tests-smalltalkCI.1570035215' message 'Fix testPromptToProceed for non-interactive modes.' id 'eef46095-980e-47b5-bb71-80cd191e2ac5' date '4 September 2020' time '3:26:46.138711 pm' author 'smalltalkCI' ancestors ((name 'SmalltalkCI-Pharo-Tests-smalltalkCI.1570035214' message 'Remove testPromptToProceedClosesProgress.
It doesn''t seem necessary in Pharo.' id 'a494f12e-de6a-0d00-bc37-8a3809421138' date '4 September 2020' time '3:00:00.106794 pm' author 'smalltalkCI' ancestors ((name 'SmalltalkCI-Pharo-Tests-smalltalkCI.1570035213' message 'Test promptToProceedImpl' id '37f28c1c-de6a-0d00-96df-61a7017a29f1' date '4 September 2020' time '2:54:51.52168 pm' author 'smalltalkCI' ancestors ((name 'SmalltalkCI-Pharo-Tests-GOC.1570035212' message 'Adapt the baseline to exclude coverage support in Pharo 3/4' id '44a327a2-6250-0d00-8dbe-a53704c51116' date '3 October 2019' time '9:40:54.762476 am' author 'GOC' ancestors ((name 'SmalltalkCI-Pharo-Tests-CompatibleUserName.1570035211' message 'Fix #441 Use #refersToLiteral: method in Pharo to discover methods including the <ignoreForCoverage> pragma
' id '6a74c47f-9a7c-5c1a-81bf-cb905dbb4a6e' date '2 October 2019' time '1:53:31 pm' author 'CompatibleUserName' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())

hernanmd · 2024-08-24T22:30:25Z

I need to understand how checks are run in this repository. I've sent a small

repository/SmalltalkCI-Pharo-Tests.package/monticello.meta/version is also missing:

(name 'SmalltalkCI-Pharo-Tests-smalltalkCI.1570035215' message 'Fix testPromptToProceed for non-interactive modes.' id 'eef46095-980e-47b5-bb71-80cd191e2ac5' date '4 September 2020' time '3:26:46.138711 pm' author 'smalltalkCI' ancestors ((name 'SmalltalkCI-Pharo-Tests-smalltalkCI.1570035214' message 'Remove testPromptToProceedClosesProgress.
It doesn''t seem necessary in Pharo.' id 'a494f12e-de6a-0d00-bc37-8a3809421138' date '4 September 2020' time '3:00:00.106794 pm' author 'smalltalkCI' ancestors ((name 'SmalltalkCI-Pharo-Tests-smalltalkCI.1570035213' message 'Test promptToProceedImpl' id '37f28c1c-de6a-0d00-96df-61a7017a29f1' date '4 September 2020' time '2:54:51.52168 pm' author 'smalltalkCI' ancestors ((name 'SmalltalkCI-Pharo-Tests-GOC.1570035212' message 'Adapt the baseline to exclude coverage support in Pharo 3/4' id '44a327a2-6250-0d00-8dbe-a53704c51116' date '3 October 2019' time '9:40:54.762476 am' author 'GOC' ancestors ((name 'SmalltalkCI-Pharo-Tests-CompatibleUserName.1570035211' message 'Fix #441 Use #refersToLiteral: method in Pharo to discover methods including the <ignoreForCoverage> pragma
' id '6a74c47f-9a7c-5c1a-81bf-cb905dbb4a6e' date '2 October 2019' time '1:53:31 pm' author 'CompatibleUserName' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())

@theseion, I've updated the PR, but there is another missing "version" file in one of the builds (again I don't know if this is related since it fails in a Pharo-32 build)

FileDoesNotExist: File @ /home/runner/work/smalltalkCI/smalltalkCI/repository/SmalltalkCI-Core.package/monticello.meta/version.

Could you explain a bit what these are or how do you get the content of those?

theseion · 2024-08-25T16:10:01Z

Previously, the version file needed to exist in every package. So we need to put back the file for every package that is loaded for older Pharo builds. Probably best to check them out from a previously known good version. For example, c37fbbf457de9b04e870248a9d51e56bdaa66928.

hernanmd · 2024-08-26T08:00:54Z

Previously, the version file needed to exist in every package. So we need to put back the file for every package that is loaded for older Pharo builds. Probably best to check them out from a previously known good version. For example, c37fbbf457de9b04e870248a9d51e56bdaa66928.

Thanks @theseion !
So it could be integrated or it needs additional changes?

theseion · 2024-08-26T17:45:17Z

The missing version files were all deleted as part of your PR. You've deleted some in multiple commits of the PR, actually, you've deleted one version file which you had already put back in a previous commit. As I had written above, Pharo version control should not be used to commit changes to this repository, unless you then clean up the commit.

You should check out the version files from master and create a new commit. Once you've pushed that commit, the build should run through.

…commit changes to this repository'

hernanmd · 2024-08-26T20:57:29Z

Thanks Max, it is clearer to me now.

I re-did the PR without using Pharo, only with the relevant changes. There is only one error https://github.com/hpi-swa/smalltalkCI/actions/runs/10566051630/job/29271938542?pr=656

Loading baseline of BaselineOfSmalltalkCI...MessageNotUnderstood: False>>at:ifAbsent:
False(Object)>>doesNotUnderstand: #at:ifAbsent:
MetacelloPharo30Platform(MetacelloPlatform)>>stackCacheFor:cacheClass:at:doing: in Block: [ :dict | ...
MetacelloPharo30Platform(MetacelloPlatform)>>useStackCacheDuring:defaultDictionary: in Block: [ ^ aBlock value: dict ]
...

Do you have any hints about this error?

It seems strange the whole CI Pharo builds are "blocked" by a 32-bit 3.0 image failing...

theseion · 2024-08-27T05:35:12Z

You're using #at:ifAbsent: in #ignorePackageNotificationClass. That's not portable, unfortunately, because not all implementations of SystemDictionary have that method. You need to use #at: with a nil check.

With a couple of exceptions, any failing test will immediately stop the pipeline. This is to save resources because the pipeline takes so long to run.

…ortable'

hernanmd · 2024-08-27T12:15:00Z

Hi again Max.
There are now two Moose images failing, but they seem to come from a script:

The error is:

Extracting and preparing Moose64-12 image...
mv: cannot stat '/home/runner/work/smalltalkCI/smalltalkCI/_builds/*.image': No such file or directory

Error with status code 1:
347 pharo::prepare_moose_image /home/runner/work/smalltalkCI/smalltalkCI/pharo/run.sh
Error: Process completed with exit code 1.

Is this related to #657?

fniephaus · 2024-08-27T15:14:53Z

maybe the Moose error is related to #657

...alltalkCI-Core.package/SCIMetacelloLoadSpec.class/instance/ignorePackageNotificationClass.st

theseion · 2024-08-27T19:06:46Z

The issue with Moose has been fixed.

…lass

…PackageLoaded

… with other plaforms for tests

theseion · 2024-08-28T05:38:39Z

Thanks @hernanmd!

theseion requested changes Aug 23, 2024

View reviewed changes

hernanmd requested a review from theseion August 23, 2024 15:48

hernanmd closed this Aug 26, 2024

hernanmd force-pushed the do_not_use_author_in_P13 branch from c15a6bd to 75da829 Compare August 26, 2024 19:22

Hernán Morales Durand added 2 commits August 26, 2024 21:28

Updated changes because 'Pharo version control should not be used to …

233b8d3

…commit changes to this repository'

Trigger PR update

2800576

hernanmd reopened this Aug 26, 2024

Use at: with a nil check instead of at:ifAbsent: because 'it is not p…

807a979

…ortable'

hernanmd closed this Aug 27, 2024

hernanmd reopened this Aug 27, 2024

theseion reviewed Aug 27, 2024

View reviewed changes

...alltalkCI-Core.package/SCIMetacelloLoadSpec.class/instance/ignorePackageNotificationClass.st Outdated Show resolved Hide resolved

Hernán Morales Durand and others added 5 commits August 27, 2024 22:02

Dispatch ignorePackageNotificationClass through SmalltalkCI platformC…

7625c78

…lass

Merge branch 'hpi-swa:master' into do_not_use_author_in_P13

73b27a5

Try using includesKey: instead of (at:) ifNil:

e4c6739

I think we don't need the P13 version of ignorePackageNotificationClass

e515bb3

Avoid the mess of using Notification and re-introduce MetacelloIgnore…

7e3bce0

…PackageLoaded

Hernán Morales Durand added 4 commits August 28, 2024 04:29

Add missing README.md

92f5df5

Add method to ignore author behavior in P13 but keeping compatibility…

af33caf

… with other plaforms for tests

Fix inconsistency in method extension name

6c1f844

Try inconsistency fix again

e43b3c7

theseion approved these changes Aug 28, 2024

View reviewed changes

theseion merged commit 57dfe32 into hpi-swa:master Aug 28, 2024
81 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use empty author in SmalltalkCIPharo13 #656

Use empty author in SmalltalkCIPharo13 #656

hernanmd commented Aug 21, 2024 •

edited

Loading

hernanmd commented Aug 21, 2024

theseion commented Aug 22, 2024

hernanmd commented Aug 22, 2024

theseion commented Aug 23, 2024

theseion left a comment

theseion commented Aug 24, 2024

hernanmd commented Aug 24, 2024

theseion commented Aug 25, 2024

hernanmd commented Aug 26, 2024

theseion commented Aug 26, 2024

hernanmd commented Aug 26, 2024

theseion commented Aug 27, 2024

hernanmd commented Aug 27, 2024 •

edited

Loading

fniephaus commented Aug 27, 2024

theseion commented Aug 27, 2024

theseion commented Aug 28, 2024

Use empty author in SmalltalkCIPharo13 #656

Use empty author in SmalltalkCIPharo13 #656

Conversation

hernanmd commented Aug 21, 2024 • edited Loading

hernanmd commented Aug 21, 2024

theseion commented Aug 22, 2024

hernanmd commented Aug 22, 2024

theseion commented Aug 23, 2024

theseion left a comment

Choose a reason for hiding this comment

theseion commented Aug 24, 2024

hernanmd commented Aug 24, 2024

theseion commented Aug 25, 2024

hernanmd commented Aug 26, 2024

theseion commented Aug 26, 2024

hernanmd commented Aug 26, 2024

theseion commented Aug 27, 2024

hernanmd commented Aug 27, 2024 • edited Loading

fniephaus commented Aug 27, 2024

theseion commented Aug 27, 2024

theseion commented Aug 28, 2024

hernanmd commented Aug 21, 2024 •

edited

Loading

hernanmd commented Aug 27, 2024 •

edited

Loading