-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pharo12 builds failing due to removal of Time>>millisecondsToRun: #625
Conversation
…w subclasses to override it
…malltalkCI when sending `timeToRun:`
…s receiver instead of `SmalltalkCI`
I fixed the mistake in the baseline for Pharo 3 that made builds fail after the class package change. I do wonder if these old versions should still be supported in the future though. |
Thanks for fixing this, @jbrichau. @theseion, could you please take a look before we merge this? thanks!
If the Pharo community doesn't use them anymore, we can drop them. Users could still use an old version of smalltalkCI if they really need to test old versions. But as long as the changes are relatively small, I think we could keep them around. |
Something's fishy. They simply moved the classes to a different package. That method shouldn't have gotten lost. It appears that the build version is stuck at a commit from December. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The baseline changes fix the dependency issue when loading the baseline, I presume?
@theseion The dependency issue is solved by moving the class between packages in commit 5ca8872. But then I needed to also fix the baseline for pharo 3 and 4 because it was expecting the class to be in that wrong package (see https://github.com/hpi-swa/smalltalkCI/actions/runs/7518470953/job/20465859552) |
I should have read your description properly, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @jbrichau!
Pharo12 builds started failing (see issue #623).
Changes in this PR fix this issue as shown in build https://github.com/SeasideSt/Grease/actions/runs/7518460089
that uses the fork of this PR.
While making these changes, I also encountered a load dependency failure due to a class for the code coverage implementation in Pharo that was in the Core package rather than the Coverage package. I moved it to fix that issue as well.
(re-create of PR #624)