Skip to content

Commit

Permalink
Merge pull request #625 from jbrichau/fix-issue-623
Browse files Browse the repository at this point in the history
Fix Pharo12 builds failing due to removal of Time>>millisecondsToRun:
  • Loading branch information
fniephaus committed Jan 16, 2024
2 parents 3f608f0 + d5eb761 commit 6a8c18c
Show file tree
Hide file tree
Showing 14 changed files with 15 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ setUpPharo3And4Packages: spec
includes: #('Ston')
].
spec
package: 'SmalltalkCI-Core' with: [ spec includes: #('SmalltalkCI-Pharo-Core') ];
package: 'SmalltalkCI-Core'
with: [ spec includes: #('SmalltalkCI-Pharo-Core') ];
package: 'SmalltalkCI-Pharo-Core'
with: [ spec requires: #('SmalltalkCI-Core' 'SmalltalkCI-Coverage-Core') ];
with: [ spec requires: #('SmalltalkCI-Core') ];
package: 'SmalltalkCI-Coverage-Core'
with: [ spec includes: #('SmalltalkCI-Pharo-Coverage-Core') ];
package: 'SmalltalkCI-Pharo-Coverage-Core'
with: [ spec requires: #('SmalltalkCI-Coverage-Core' 'SmalltalkCI-Pharo-Core') ];
package: 'SmalltalkCI-Pharo-Tests' with: [ spec requires: #('SmalltalkCI-Pharo-Core') ].
spec group: 'tests' with: #('SmalltalkCI-Pharo-Tests' 'SmalltalkCI-Coverage-Tests')
]
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
running
run
[ self setUp. suiteTime := SmalltalkCI timeToRun: [ self runAll ] ] ensure: [ self tearDown ]
[ self setUp. suiteTime := SmalltalkCI platformClass timeToRun: [ self runAll ] ] ensure: [ self tearDown ]
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ runCase: aTestCase
| result |
SmalltalkCI printDebug: aTestCase asString.
result := SCITestRunnerResult new testCase: aTestCase; yourself.
result time: (SmalltalkCI timeToRun: [
result time: (SmalltalkCI platformClass timeToRun: [
[ [ self basicRunCase: aTestCase ]
on: self class errorExceptions
do: [ :err |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ folding
fold: aTitle on: aStream block: aBlock
| timeToRun |
aStream nextPutAll: (self foldTitle: aTitle); flush.
timeToRun := SmalltalkCI timeToRun: [ aBlock value ].
timeToRun := self timeToRun: [ aBlock value ].
aStream nextPutAll: self newLine, ' > Done in ', (self stringFor: timeToRun maxDecimalPlaces: 3), 'ms.', self newLine; flush
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
compatibility
timeToRun: aBlock

^ aBlock millisecondsToRun
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"category" : "SmalltalkCI-Pharo-Core",
"category" : "SmalltalkCI-Pharo-Coverage-Core",
"classinstvars" : [
],
"classvars" : [
Expand Down

0 comments on commit 6a8c18c

Please sign in to comment.