-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update price service to use helium-lib #832
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cc94c00
Update price to use helium-lib to retrieve on chain price
bbalser 7fb7e90
remove unused dep
bbalser 8a25b13
remove commented out code
bbalser 7d7c65e
Add async featur to anchor-client
bbalser 3d7b6e7
remove commented code
bbalser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,20 @@ | ||
use helium_proto::BlockchainTokenTypeV1; | ||
use helium_lib::token::Token; | ||
|
||
const PRICE_GAUGE: &str = concat!(env!("CARGO_PKG_NAME"), "_", "price_gauge"); | ||
|
||
pub struct Metrics; | ||
|
||
impl Metrics { | ||
pub fn update(counter: String, token_type: BlockchainTokenTypeV1, price: f64) { | ||
increment_counter(counter, token_type); | ||
set_gauge(token_type, price) | ||
pub fn update(counter: String, token: Token, price: f64) { | ||
increment_counter(counter, token); | ||
set_gauge(token, price) | ||
} | ||
} | ||
|
||
fn increment_counter(counter: String, token_type: BlockchainTokenTypeV1) { | ||
metrics::counter!(counter, "token_type" => token_type.as_str_name()).increment(1); | ||
fn increment_counter(counter: String, token: Token) { | ||
metrics::counter!(counter, "token_type" => token.to_string()).increment(1); | ||
} | ||
|
||
fn set_gauge(token_type: BlockchainTokenTypeV1, value: f64) { | ||
metrics::gauge!(PRICE_GAUGE, "token_type" => token_type.as_str_name()).set(value); | ||
fn set_gauge(token: Token, value: f64) { | ||
metrics::gauge!(PRICE_GAUGE, "token_type" => token.to_string()).set(value); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time to extract
helium-lib
out of wallet? maybe push intohelium-program-library
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not? The whole point is that compiling all of HPL is very brittle and complicated.. helium-lib only relies on the IDLs for the HPL defined programs