Update price service to use helium-lib #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhay
reviewed
Jun 22, 2024
| @@ -66,15 +66,16 @@ sqlx = { version = "0", features = [ | |||
| ] } | |||
| helium-anchor-gen = { git = "https://github.com/helium/helium-anchor-gen.git" } | |||
| helium-crypto = { version = "0.8.4", features = ["sqlx-postgres", "multisig"] } | |||
| helium-lib = { git = "https://github.com/helium/helium-wallet-rs.git", branch = "master" } | |||
There was a problem hiding this comment.
time to extract helium-lib out of wallet? maybe push into helium-program-library?
There was a problem hiding this comment.
probably not? The whole point is that compiling all of HPL is very brittle and complicated.. helium-lib only relies on the IDLs for the HPL defined programs
andymck
approved these changes
Jun 24, 2024
maplant
reviewed
Jun 25, 2024
maplant
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
price now uses helium-lib to get sponsored pyth price off chain