Automatically download data sets #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
reviewed
Mar 13, 2024
andymck
reviewed
Mar 14, 2024
maplant
changed the title
bbalser
reviewed
Apr 12, 2024
andymck
reviewed
Apr 26, 2024
andymck
reviewed
May 9, 2024
There was a problem hiding this comment.
whilst i do need to take another pass at this...it generally looks good to me...one point I want to note is that the datasets module is somewhat difficult to read through...there is a lot going on in there I think breaking out its concerns to distinct files would help with this.
andymck
reviewed
May 10, 2024
bbalser
reviewed
May 16, 2024
bbalser
approved these changes
May 17, 2024
andymck
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates two new daemons for checking for new data set files and downloading and processing them once their timestamp has passed. This should be fairly robust, I prevent the download daemon from shutting down in the middle of downloading, but should that occur for whatever reason no errors should be incurred from restart.