Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hex_assignments (boosting_oracles) as separate create #807

Closed
wants to merge 0 commits into from

Conversation

kurotych
Copy link
Member

@kurotych kurotych commented May 8, 2024

It makes it possible to reuse hex_assignments code without bloated mobile-verifier dependencies (which causes dependency conflict issues)

@kurotych kurotych marked this pull request as draft May 8, 2024 11:36
@kurotych kurotych marked this pull request as ready for review May 8, 2024 12:24
@bbalser
Copy link
Contributor

bbalser commented May 9, 2024

I think we should rename the crate hex_assignments rather than boosting_oracles. I didn't like that name before, but I really don't like it as a crate.

@kurotych kurotych changed the title Make boosting_oracles as separate create Make hex_assignments (boosting_oracles) as separate create May 9, 2024
Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if #760 is likely to get merged soon it might be less trouble to wait until then and recut this

@kurotych
Copy link
Member Author

kurotych commented May 9, 2024

if #760 is likely to get merged soon it might be less trouble to wait until then and recut this

Maybe it is worth moving "boosting_oracles" to a separate crate in your PR? @maplant

Since this module was reworked there.

@maplant
Copy link
Contributor

maplant commented May 15, 2024

@kurotych do you want to use the DataSetDownloader, or would you rather we keep that in mobile_verifier? If you plan on using it for updating the data sets we'd be happy to include it, but it would bring in a rather large set of dependencies with it

@kurotych
Copy link
Member Author

but it would bring in a rather large set of dependencies with it

It is definitely what I don't want. I can't use the mobile_verifier as a dependency in my project because of dependency conflicts, that's why I want to create a separate crate.

do you want to use the DataSetDownloader, or would you rather we keep that in mobile_verifier

If it brings a lot of deps I believe it is worth keeping it in the mobile_verifier for now.


What I need is hex_assignments logic with a minimal amount of dependencies to use in my project.

Feel free to finish #760 in your way, I don't want to interrupt you. I'll investigate what I can do after you merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants