Add PR builder GitHub Workflow for Code snippets #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JackPGreen
reviewed
Sep 9, 2024
There was a problem hiding this comment.
I am concerned about the scalability of this as Hazelcast dependencies change, and think using hazelcast-parent would be a better base.
But I guess we can figure that out we try it...
JackPGreen
reviewed
Sep 9, 2024
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' |
There was a problem hiding this comment.
JackPGreen
approved these changes
Sep 9, 2024
|
Thanks for the review, Jack. |
oliverhowell
approved these changes
Sep 9, 2024
|
Thank you for the review, Oliver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GitHub workflow to compile the Java code on pull requests (to verify the code still works with given Hazelcast version).
It also adds a dependabot configuration.
Originally the changes were part of the #1263