Reorganize security documentation [DOCS-104] #1263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kwart
force-pushed
the
cleanup/6.0/security
branch
from
019819f
to
f35f174
Compare
kwart
force-pushed
the
cleanup/6.0/security
branch
from
19fe961
to
076f656
Compare
…te Java code (DOCS-104)
kwart
force-pushed
the
cleanup/6.0/security
branch
from
076f656
to
a5a60cb
Compare
JackPGreen
requested changes
Sep 9, 2024
There was a problem hiding this comment.
I have made some suggestions, but as a caveat:
reorganizes and updates Hazelcast Security related topics;
I'm assuming this content is all correct because... you would know.
I've reviewed only from a language POV.
- introduces Maven POM file allowing compiling the sample Java code included in the examples documentation module;
- adds GitHub workflow to compile the Java code on pull requests (to verify the code still works with given Hazelcast version);
This PR is really, really large.
Could we split the validation of code samples into a seperate PR from updating the documentation? The reviewers are probably different anyway.
Not sure if possible without lots of conflicts.
Co-authored-by: Jack Green <[email protected]>
kwart
added a commit
that referenced
this pull request
Sep 9, 2024
This PR adds GitHub workflow to compile the Java code on pull requests (to verify the code still works with given Hazelcast version). It also adds a dependabot configuration. Originally the changes were part of the #1263
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
Co-authored-by: Jack Green <[email protected]>
JackPGreen
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes and updates Hazelcast Security related topics;
Original structure of the
Securing a Clusterpart:New structure:
