Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DI issue and Cleaned up code #77

Closed
wants to merge 1 commit into from
Closed

Fixed DI issue and Cleaned up code #77

wants to merge 1 commit into from

Conversation

rafsanulhasan
Copy link

@rafsanulhasan rafsanulhasan commented Mar 19, 2023 •
edited
Loading

Closes #20

Registered httpclient and RESFulSense in .NET fashion.

  • used Microsoft.Extensions.Http to register HttpClient
  • setup base url for the http client in the DI
  • Used a DelegatingHangler to set Bearer tokens and Organization id headers in the request
  • Registered IRESTFulSenseHttpFactoryClient
  • Cleaned up initialization code from broker.

Used constant strings instead of magic strings for better readability.

  • Removed magic strings ("Bearer", "application/json")
  • Removed some warnings (, usages)

DI Issue: registered httpclient and RESFulSense in .NET fashion.
7ad41be 
Used constant strings instead of magic strings for better readability.

Removed some warnings
@rafsanulhasan rafsanulhasan mentioned this pull request Mar 19, 2023
Open
@hassanhabib
Copy link
Owner

Please review Contribution Rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MINOR FIX: PENDING New Version of RESTFulSense with HttpFactory
2 participants
@rafsanulhasan @hassanhabib