MINOR FIX: PENDING New Version of RESTFulSense with HttpFactory

[jodendaal]

If creating a HttpClient manually, i.e new HttpClient() that is either disposed frequently or is long running,it is recommended to create your own [HttpMessageHandler] and handle lifetimes etc to avoid socket exhaustion and DNS update failures. I would recommend just using the IHttpClientFactory to create new http instances which handles all of this really well.

I have dealt with this issue quite a few times in production environments with long running high through put scenarios. It's not an obvious issue, but eventually rears its ugly head.

Further Reading

https://learn.microsoft.com/en-us/dotnet/architecture/microservices/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests

https://www.aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/

[hassanhabib]

@BrianLParker

[BrianLParker]

http://byterot.blogspot.com/2016/07/singleton-httpclient-dns.html

Use the HttpClientFactory.
The HttpClientFactory keeps its own pool of HttpClientHandlers and recycles them periodically.

The library should inject the HttpClientFactory or request it as a required service, and then create a configured client that can be reused for the OpenAI endpoint.

Thankyou @jodendaal for pointing this out.

[hassanhabib]

@jodendaal please create an issue on the RESTFulSense Project and change the name for this one to MINOR FIX: PENDING New Version of RESTFulSense with HttpFactory

cc: @cjdutoit

[rafsanulhasan]

@hassanhabib I've just created a PR #77 demonstrating how to use IHttpClientFactory from Microsoft.Extensions.Http. We can use that library to register both our http client and IRESTFulClientFactory in DI. I think this way we can have a cleaner code in the OpenAIBroker.

[hassanhabib]

@rafsanulhasan every broker should contain it's own dependencies. Brokers should only receive configurations and initialize it's own external libraries.

Refer to this portion here in The Standard:
https://github.com/hassanhabib/The-Standard/blob/master/1.%20Brokers/1.%20Brokers.md#123-own-their-configurations

We should have bits and pieces of Broker's requirements spread across the app.

[rafsanulhasan]

@hassanhabib I've just created another PR #84 which allows you to put own dependencies for different brokers.

This time tried to maintain the standard.