Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question : is it usefull / required to create the HttpClient using the default Microsoft way + using Polly ? #106

Open
StefH opened this issue Mar 20, 2023 · 3 comments

Comments

@jodendaal
Copy link

I'm a big fan of doing it that way, it gives the consumer a bit more control over how they use it, I use polly all the time for retry polices. The main reason I use it though was mentioned in this issue #20. It does mean exposing some of the internals of the broker which I don't think @hassanhabib likes to much. I may be wrong though :)

@rafsanulhasan
Copy link

Hi @jodendaal, I think I will create a new PR to incorporate different resiliency related issues with Polly.
I already created a PR #84 where I registered HttpClient using Microsoft.Extensions.Http and used Delegating Handler in order to delegate the responsibility of adding Bearer Token and OrganizationId to the request headers. Injected IHttpClientFactory into broker to resolve HttpClient.
After this PR gets merged, I'll use Polly to implement resiliency in HttpClient.

@rafsanulhasan
Copy link

rafsanulhasan commented Mar 21, 2023

@StefH You can also take a look and make some comments on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants