Merge pull request #1116 from hashicorp/nf/oct23-saml-settings-flakes

Fix flaky TFESAMLSettings resource tests, add comments
hashicorp · Oct 25, 2023 · 7efe29a · 7efe29a
2 parents 0f88ce7 + d992cd3
commit 7efe29a
Show file tree

Hide file tree

Showing 2 changed files with 213 additions and 194 deletions.
diff --git a/internal/provider/data_source_saml_settings_test.go b/internal/provider/data_source_saml_settings_test.go
@@ -9,6 +9,12 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
+// FLAKE ALERT: SAML settings are a singleton resource shared by the entire TFE
+// instance, and any test touching them is at high risk to flake.
+// This test is fine, because it only checks that the attributes have SOME
+// value. Testing for any _particular_ value would not be viable, because
+// `resource_tfe_saml_settings_test.go` exists. See that file for more color on
+// this.
 func TestAccTFESAMLSettingsDataSource_basic(t *testing.T) {
 	resourceAddress := "data.tfe_saml_settings.foobar"
 	resource.Test(t, resource.TestCase{