Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix flaky TFESAMLSettings resource tests, add comments
These tests flake violently, because they're competing for control of global singleton state. The flakes show a distinctive pattern: they only flake when at least two of the resource test funcs end up on separate test runner partitions in CI, and re-running a single one failed partition alone always succeeds (because there's no concurrent competition anymore). The fix is to make sure all of these tests ALWAYS run in serial on a single test runner partition. Smooshing into a single outer func and calling t.Run without t.Parallel seems like it should fit the bill.
- Loading branch information