Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prerequisite in cloud-provider #665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove prerequisite in cloud-provider #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/rancher/cloud-provider.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ For a detailed support matrix, please refer to the **Harvester CCM & CSI Driver
### Prerequisites
- The Kubernetes cluster is built on top of Harvester virtual machines.
- The Harvester virtual machines run as guest Kubernetes nodes are in the same namespace.
- The Harvester virtual machine guests' hostnames match their corresponding Harvester virtual machine names. Guest cluster Harvester VMs can't have different hostnames than their Harvester VM names when using the Harvester CSI driver. We hope [to remove this limitation](https://github.com/harvester/harvester/issues/4396) in a future release of Harvester.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandboat can you also help figure out since which version we don't have this restriction anymore? Thanks!

Copy link
Member Author

@brandboat brandboat Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix was introduced since v1.3.0

corresponding commit is here harvester/harvester-csi-driver@d8da888 (in node-manager v0.1.6+)
in harvester v1.3.0 chart, node-manager version is v0.2.3 (https://github.com/harvester/harvester/blob/v1.3.0/deploy/charts/harvester/Chart.yaml#L56)
in harvester v1.2.2 chart, node-manager version is v0.1.5 (https://github.com/harvester/harvester/blob/v1.2.2/deploy/charts/harvester/Chart.yaml#L56)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the csi driver version is relevant here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry... I'm not sure what I was thinking then, will edit comment later. Thanks

Copy link
Member Author

@brandboat brandboat Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix was introduced since harvester-csi-driver release v0.1.6, commit: harvester/harvester-csi-driver@d8da888, image tag: v0.1.6 chart version: v0.1.18 (which default use image "v0.1.7")

And was included in rke2 versions:


:::info important

Expand Down
1 change: 0 additions & 1 deletion versioned_docs/version-v1.3/rancher/cloud-provider.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ For a detailed support matrix, please refer to the **Harvester CCM & CSI Driver
### Prerequisites
- The Kubernetes cluster is built on top of Harvester virtual machines.
- The Harvester virtual machines run as guest Kubernetes nodes are in the same namespace.
- The Harvester virtual machine guests' hostnames match their corresponding Harvester virtual machine names. Guest cluster Harvester VMs can't have different hostnames than their Harvester VM names when using the Harvester CSI driver. We hope [to remove this limitation](https://github.com/harvester/harvester/issues/4396) in a future release of Harvester.

:::info important

Expand Down