-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prerequisite in cloud-provider #665
base: main
Are you sure you want to change the base?
Conversation
@@ -39,7 +39,6 @@ For a detailed support matrix, please refer to the **Harvester CCM & CSI Driver | |||
### Prerequisites | |||
- The Kubernetes cluster is built on top of Harvester virtual machines. | |||
- The Harvester virtual machines run as guest Kubernetes nodes are in the same namespace. | |||
- The Harvester virtual machine guests' hostnames match their corresponding Harvester virtual machine names. Guest cluster Harvester VMs can't have different hostnames than their Harvester VM names when using the Harvester CSI driver. We hope [to remove this limitation](https://github.com/harvester/harvester/issues/4396) in a future release of Harvester. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandboat can you also help figure out since which version we don't have this restriction anymore? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix was introduced since v1.3.0
corresponding commit is here harvester/harvester-csi-driver@d8da888 (in node-manager v0.1.6+)
in harvester v1.3.0 chart, node-manager version is v0.2.3 (https://github.com/harvester/harvester/blob/v1.3.0/deploy/charts/harvester/Chart.yaml#L56)
in harvester v1.2.2 chart, node-manager version is v0.1.5 (https://github.com/harvester/harvester/blob/v1.2.2/deploy/charts/harvester/Chart.yaml#L56)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the csi driver version is relevant here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry... I'm not sure what I was thinking then, will edit comment later. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix was introduced since harvester-csi-driver release v0.1.6, commit: harvester/harvester-csi-driver@d8da888, image tag: v0.1.6 chart version: v0.1.18
(which default use image "v0.1.7")
And was included in rke2 versions:
- rke2 1.31
>=
v1.31.0+rke2r1, commit: rancher/rke2@7a81df0 - rke2 1.30
>=
v1.30.0+rke2r1, commit: rancher/rke2@7a81df0 - rke2 1.29
>=
v1.29.2+rke2r1, commit: rancher/rke2@7a81df0 - rke2 1.28
>=
v1.28.7+rke2r1 , commit: rancher/rke2@42eefe4 - rke2 1.27
>=
v1.27.11+rke2r1 , commit: rancher/rke2@3353077 - rke2 1.26
>=
v1.26.14+rke2r1 , commit: rancher/rke2@0b6e0d8
|
this is a follow up from harvester/harvester#4396
Remove prerequisite as below in cloud-provider v1.3, v1.4 doc