Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regression, gubernator should start without a config file #5

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixed regression, gubernator should start without a config file #5

merged 1 commit into from
Mar 26, 2024

Conversation

thrawn01
Copy link
Collaborator

@thrawn01 thrawn01 commented Mar 22, 2024 •
edited
Loading

Purpose

Previous version broke the ability to start gubernator without a config file.

Implementation

  • Added a test for running gubernator from the CLI
  • Added LABEL to image to tie image to the github repo
  • Added exception to flag parser for flag provided but not defined as we need to pass additional flags in during a test
  • tracerCloser is now closed when Main() returns

This should fix #3

@thrawn01 thrawn01 requested a review from Baliedge as a code owner March 22, 2024 21:50
@thrawn01 thrawn01 linked an issue Mar 22, 2024 that may be closed by this pull request
v2.4.0 added breaking change now requiring a configuration file. #3
Closed
@thrawn01 thrawn01 self-assigned this Mar 22, 2024
@thrawn01 thrawn01 merged commit b5893f5 into master Mar 26, 2024
4 checks passed
@thrawn01 thrawn01 mentioned this pull request Mar 26, 2024
Merged
@thrawn01 thrawn01 mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baliedge Baliedge Baliedge approved these changes

Assignees

@thrawn01 thrawn01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.4.0 added breaking change now requiring a configuration file.
2 participants
@thrawn01 @Baliedge