Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.4.0 added breaking change now requiring a configuration file. #3

Closed
pbennett opened this issue Mar 22, 2024 · 1 comment · Fixed by #5 or #6
Closed

v2.4.0 added breaking change now requiring a configuration file. #3

pbennett opened this issue Mar 22, 2024 · 1 comment · Fixed by #5 or #6
Assignees
@thrawn01

Comments

@pbennett
Copy link

This has always been defined as an optional file and environment overrides were fine.
Upgrading from 2.3.2 to 2.4 is hard failure in all of my deployments.

mailgun/gubernator@452c5b5#diff-906dccb3a093f9867818c8b4ded48155bae5a39d40f0c408869e8b0820b8e60dR79
@thrawn01 thrawn01 linked a pull request Mar 22, 2024 that will close this issue
Fixed regression, gubernator should start without a config file #5
Merged
@thrawn01 thrawn01 mentioned this issue Mar 22, 2024
Merged
@thrawn01 thrawn01 self-assigned this Mar 22, 2024
@thrawn01
Copy link
Collaborator

@pbennett thank you for reporting this, I have a PR with a fix and added a test for this regression.

@thrawn01 thrawn01 mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thrawn01 thrawn01

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@thrawn01 @pbennett